-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-37818: Set white background for PageSection component where needed #1777
CNV-37818: Set white background for PageSection component where needed #1777
Conversation
Set the background for Patternfly PageSection component we use back to white due to the change of the default setting of the component from white to grey. Adjust the component by adding "variant={PageSectionVariants.light}" to achieve the expected look in the following pages: - Template Details tab - Template Scheduling tab - Template Scripts tab - Template Parameters tab - DataSource details (from Bootable volumes list), incl. Conditions part - DataImportCron details (from DataSource details) - MigrationPolicy details Fixes https://issues.redhat.com/browse/CNV-37818
@hstastna: This pull request references CNV-37818 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-37818
Set the background for Patternfly
PageSection
component we use back to white due to the change of the default setting of the component from white to grey. Adjust the component by addingvariant={PageSectionVariants.light}
to achieve the expected look in the following pages:🎥 Screenshots
Before:
After: