Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-37818: Set white background for PageSection component where needed #1777

Conversation

hstastna
Copy link

@hstastna hstastna commented Feb 5, 2024

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-37818

Set the background for Patternfly PageSection component we use back to white due to the change of the default setting of the component from white to grey. Adjust the component by adding variant={PageSectionVariants.light} to achieve the expected look in the following pages:

  • Template Details tab
  • Template Scheduling tab
  • Template Scripts tab
  • Template Parameters tab
  • DataSource details (from Bootable volumes list), incl. Conditions part
  • DataImportCron details (from DataSource details page)
  • MigrationPolicy details

🎥 Screenshots

Before:
ds_before
ex_before

After:
ds_after
ex_after

Set the background for Patternfly PageSection component we use back to
white due to the change of the default setting of the component from
white to grey. Adjust the component by adding
"variant={PageSectionVariants.light}" to achieve the expected look
in the following pages:
- Template Details tab
- Template Scheduling tab
- Template Scripts tab
- Template Parameters tab
- DataSource details (from Bootable volumes list), incl. Conditions part
- DataImportCron details (from DataSource details)
- MigrationPolicy details

Fixes https://issues.redhat.com/browse/CNV-37818
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 5, 2024

@hstastna: This pull request references CNV-37818 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-37818

Set the background for Patternfly PageSection component we use back to white due to the change of the default setting of the component from white to grey. Adjust the component by adding variant={PageSectionVariants.light} to achieve the expected look in the following pages:

  • Template Details tab
  • Template Scheduling tab
  • Template Scripts tab
  • Template Parameters tab
  • DataSource details (from Bootable volumes list), incl. Conditions part
  • DataImportCron details (from DataSource details page)
  • MigrationPolicy details

🎥 Screenshots

Before:
ds_before
ex_before

After:
ds_after
ex_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 5, 2024
@hstastna
Copy link
Author

hstastna commented Feb 5, 2024

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@hstastna
Copy link
Author

hstastna commented Feb 5, 2024

/retest

1 similar comment
@metalice
Copy link
Member

metalice commented Feb 6, 2024

/retest

@metalice
Copy link
Member

metalice commented Feb 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 6, 2024
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8adfcc7 into kubevirt-ui:main Feb 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants