Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-37818: Set white background for PageSection component where needed #1777

Merged
merged 1 commit into from
Feb 6, 2024
Merged

CNV-37818: Set white background for PageSection component where needed #1777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/views/datasources/dataimportcron/details/DataImportCronDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import React, { FC } from 'react';
import { RouteComponentProps } from 'react-router';

import { V1beta1DataImportCron } from '@kubevirt-ui/kubevirt-api/containerized-data-importer/models';
Expand All @@ -7,7 +7,7 @@ import {
K8sResourceCondition,
} from '@kubevirt-utils/components/ConditionsTable/ConditionsTable';
import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
import { Divider, PageSection, Title } from '@patternfly/react-core';
import { Divider, PageSection, PageSectionVariants, Title } from '@patternfly/react-core';

import { DataImportCronDetailsGrid } from './DataImportCronDetailsGrid';

Expand All @@ -18,20 +18,19 @@ type DataImportCronDetailsPageProps = RouteComponentProps<{
obj?: V1beta1DataImportCron;
};

const DataImportCronDetailsPage: React.FC<DataImportCronDetailsPageProps> = ({
obj: dataImportCron,
}) => {
const DataImportCronDetailsPage: FC<DataImportCronDetailsPageProps> = ({ obj: dataImportCron }) => {
const { t } = useKubevirtTranslation();

return (
<div>
<PageSection>
<PageSection variant={PageSectionVariants.light}>
<Title className="co-section-heading" headingLevel="h2">
{t('DataImportCron details')}
</Title>
<DataImportCronDetailsGrid dataImportCron={dataImportCron} />
</PageSection>
<Divider />
<PageSection>
<PageSection variant={PageSectionVariants.light}>
<Title className="co-section-heading" headingLevel="h2">
{t('Conditions')}
</Title>
Expand Down
10 changes: 5 additions & 5 deletions src/views/datasources/details/DataSourceDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import React, { FC } from 'react';
import { RouteComponentProps } from 'react-router';

import { V1beta1DataSource } from '@kubevirt-ui/kubevirt-api/containerized-data-importer/models';
Expand All @@ -7,7 +7,7 @@ import {
K8sResourceCondition,
} from '@kubevirt-utils/components/ConditionsTable/ConditionsTable';
import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
import { Divider, PageSection, Title } from '@patternfly/react-core';
import { Divider, PageSection, PageSectionVariants, Title } from '@patternfly/react-core';

import { DataSourceDetailsGrid } from './components/DataSourceDetailsGrid.tsx/DataSourceDetailsGrid';

Expand All @@ -18,19 +18,19 @@ type DataSourceDetailsPageProps = RouteComponentProps<{
obj?: V1beta1DataSource;
};

const DataSourceDetailsPage: React.FC<DataSourceDetailsPageProps> = ({ obj: dataSource }) => {
const DataSourceDetailsPage: FC<DataSourceDetailsPageProps> = ({ obj: dataSource }) => {
const { t } = useKubevirtTranslation();

return (
<div>
<PageSection>
<PageSection variant={PageSectionVariants.light}>
<Title className="co-section-heading" headingLevel="h2">
{t('DataSource details')}
</Title>
<DataSourceDetailsGrid dataSource={dataSource} />
</PageSection>
<Divider />
<PageSection>
<PageSection variant={PageSectionVariants.light}>
<Title className="co-section-heading" headingLevel="h2">
{t('Conditions')}
</Title>
Expand Down
23 changes: 9 additions & 14 deletions src/views/migrationpolicies/details/tabs/details/MigrationPolicyDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as React from 'react';
import React, { FC } from 'react';
import { RouteComponentProps } from 'react-router';

import { V1alpha1MigrationPolicy } from '@kubevirt-ui/kubevirt-api/kubevirt';
import { PageSection } from '@patternfly/react-core';
import { PageSection, PageSectionVariants } from '@patternfly/react-core';

import MigrationPolicyDetailsSection from './components/MigrationPolicyDetailsSection/MigrationPolicyDetailsSection';

Expand All @@ -11,17 +11,12 @@ import './MigrationPolicyDetailsPage.scss';
type MigrationPolicyDetailsPageProps = RouteComponentProps & {
obj: V1alpha1MigrationPolicy;
};
const MigrationPolicyDetailsPage: React.FC<MigrationPolicyDetailsPageProps> = ({
location,
obj: mp,
}) => {
return (
<div className="migration-policy-details-page">
<PageSection>
<MigrationPolicyDetailsSection mp={mp} pathname={location?.pathname} />
</PageSection>
</div>
);
};
const MigrationPolicyDetailsPage: FC<MigrationPolicyDetailsPageProps> = ({ location, obj: mp }) => (
<div className="migration-policy-details-page">
<PageSection variant={PageSectionVariants.light}>
<MigrationPolicyDetailsSection mp={mp} pathname={location?.pathname} />
</PageSection>
</div>
);

export default MigrationPolicyDetailsPage;
4 changes: 2 additions & 2 deletions src/views/templates/details/tabs/details/TemplateDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { TemplateModel, V1Template } from '@kubevirt-ui/kubevirt-api/console';
import SidebarEditor from '@kubevirt-utils/components/SidebarEditor/SidebarEditor';
import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
import { k8sUpdate } from '@openshift-console/dynamic-plugin-sdk';
import { Grid, GridItem, PageSection, Title } from '@patternfly/react-core';
import { Grid, GridItem, PageSection, PageSectionVariants, Title } from '@patternfly/react-core';

import TemplateDetailsLeftGrid from './components/TemplateDetailsLeftGrid';
import TemplateDetailsRightGrid from './components/TemplateDetailsRightGrid';
Expand Down Expand Up @@ -41,7 +41,7 @@ const TemplateDetailsPage: FC<TemplateDetailsPageProps> = ({ obj: template }) =>
);

return (
<PageSection>
<PageSection variant={PageSectionVariants.light}>
<SidebarEditor<V1Template> onResourceUpdate={onSubmitTemplate} resource={template}>
{(resource) => (
<>
Expand Down
3 changes: 2 additions & 1 deletion src/views/templates/details/tabs/parameters/TemplateParametersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
EmptyState,
Form,
PageSection,
PageSectionVariants,
Title,
} from '@patternfly/react-core';

Expand Down Expand Up @@ -79,7 +80,7 @@ const TemplateParametersPage: FC<TemplateParametersPageProps> = ({ obj: template
};

return (
<PageSection className="template-parameters-page">
<PageSection className="template-parameters-page" variant={PageSectionVariants.light}>
<SidebarEditor
onChange={(newTemplate) => setEditableTemplate(newTemplate)}
resource={editableTemplate}
Expand Down
4 changes: 2 additions & 2 deletions src/views/templates/details/tabs/scheduling/TemplateSchedulingTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { TemplateModel, V1Template } from '@kubevirt-ui/kubevirt-api/console';
import SidebarEditor from '@kubevirt-utils/components/SidebarEditor/SidebarEditor';
import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
import { k8sUpdate } from '@openshift-console/dynamic-plugin-sdk';
import { Grid, GridItem, PageSection, Title } from '@patternfly/react-core';
import { Grid, GridItem, PageSection, PageSectionVariants, Title } from '@patternfly/react-core';

import useEditTemplateAccessReview from '../../hooks/useIsTemplateEditable';

Expand Down Expand Up @@ -37,7 +37,7 @@ const TemplateSchedulingTab: FC<TemplateSchedulingTabProps> = ({ obj: template }
);

return (
<PageSection>
<PageSection variant={PageSectionVariants.light}>
<SidebarEditor<V1Template> onResourceUpdate={onSubmitTemplate} resource={template}>
{(resource) => (
<>
Expand Down
3 changes: 2 additions & 1 deletion src/views/templates/details/tabs/scripts/TemplateScriptsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
Flex,
FlexItem,
PageSection,
PageSectionVariants,
Title,
} from '@patternfly/react-core';
import { PencilAltIcon } from '@patternfly/react-icons';
Expand Down Expand Up @@ -68,7 +69,7 @@ const TemplateScriptsPage: FC<TemplateScriptsPageProps> = ({ obj: template }) =>
);

return (
<PageSection>
<PageSection variant={PageSectionVariants.light}>
<SidebarEditor<V1Template> onResourceUpdate={onSubmitTemplate} resource={template}>
<DescriptionList className="template-scripts-tab__description-list">
<DescriptionListGroup>
Expand Down
Loading