Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to CentOS stream9 builder #2087

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Switch to CentOS stream9 builder #2087

merged 1 commit into from
Mar 23, 2022

Conversation

maya-r
Copy link
Contributor

@maya-r maya-r commented Jan 9, 2022

What this PR does / why we need it:
Had some trouble building the centos builder on CI.
@mhenriks reverted it to be able to make some changes - let's re-introduce this change.

Special notes for your reviewer:

Release note:

Switch to CentOS Stream9 for building images

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 9, 2022
@maya-r
Copy link
Contributor Author

maya-r commented Jan 9, 2022

/hold
needs kubevirt/project-infra#1829 first.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2022
@maya-r
Copy link
Contributor Author

maya-r commented Jan 16, 2022 •
edited
Loading

/hold cancel
project-infra bootstrap image was updated.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2022
@maya-r
Copy link
Contributor Author

maya-r commented Jan 17, 2022

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2022
@awels
Copy link
Member

awels commented Feb 14, 2022

If this is ready can you take the hold off?

@awels
Copy link
Member

awels commented Feb 14, 2022

So #1983 is for updating the output containers to use centos stream 9? I am not sure if we can separate the two. The builder image builds the binaries which eventually end up in the target containers. So we would have binaries build on centos 9 being deposited into fedora 33 containers. I am fine with a short period of this being out of sync, but is #1983 ready as well?

@jsquyres jsquyres mentioned this pull request Mar 3, 2022
Merged
@alicefr
Copy link
Member

alicefr commented Mar 8, 2022 •
edited
Loading

If you don't switch at the same time the builder and the base container images, you could end up having a mismatch with the dynamic libraries and symbols. It already happen with a too old fedora package for libnbd (see this comment). This could happen even more likely if the 2 environments have 2 different OSes.

@maya-r
Switch to CentOS stream9 builder
b74bc9b 
Signed-off-by: Maya Rashish <mrashish@redhat.com>
@maya-r
Copy link
Contributor Author

maya-r commented Mar 14, 2022

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2022
@maya-r
Copy link
Contributor Author

maya-r commented Mar 14, 2022

Yeah, unfortunately our current workflow requires there to be a small window of mismatch between builder and base image.
We only update the builder after the push is done, and cannot use it for the PR we are currently building.

@maya-r
Copy link
Contributor Author

maya-r commented Mar 14, 2022

@awels both PRs are as ready as they can be - the second one needs to update BUILDER_IMAGE to the checksum that will be generated once this PR is merged.

maya-r added a commit to maya-r/containerized-data-importer that referenced this pull request Mar 15, 2022
@maya-r
DO NOT MERGE: run with locally built builder
3318a8f 
The builder is built including the changes in kubevirt#2087

Signed-off-by: Maya Rashish <mrashish@redhat.com>
@maya-r

This comment was marked as off-topic.

Sign in to view
@maya-r
Copy link
Contributor Author

maya-r commented Mar 15, 2022

Oops, this is the wrong PR

@mhenriks
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@maya-r
Copy link
Contributor Author

maya-r commented Mar 22, 2022

/retest

@awels
Copy link
Member

awels commented Mar 22, 2022

/test pull-containerized-data-importer-e2e-k8s-1.21-hpp

@maya-r
Copy link
Contributor Author

maya-r commented Mar 23, 2022

/retest-required

@kubevirt-bot kubevirt-bot merged commit 92ab271 into kubevirt:main Mar 23, 2022
maya-r added a commit to maya-r/containerized-data-importer that referenced this pull request Mar 23, 2022
@maya-r
Update builder to include kubevirt#2087, builder based on centos stream9
ccfcf4d 
Signed-off-by: Maya Rashish <mrashish@redhat.com>
maya-r added a commit to maya-r/containerized-data-importer that referenced this pull request Mar 23, 2022
@maya-r
Update builder to include kubevirt#2087, builder based on centos stream9
9ad0cfa 
Signed-off-by: Maya Rashish <mrashish@redhat.com>
maya-r added a commit to maya-r/containerized-data-importer that referenced this pull request Mar 24, 2022
@maya-r
Update builder to include kubevirt#2087, builder based on centos stream9
16e51b0 
Signed-off-by: Maya Rashish <mrashish@redhat.com>
maya-r added a commit to maya-r/containerized-data-importer that referenced this pull request Mar 28, 2022
@maya-r
Update builder to include kubevirt#2087, builder based on centos stream9
6cfe6ed 
Signed-off-by: Maya Rashish <mrashish@redhat.com>
maya-r added a commit to maya-r/containerized-data-importer that referenced this pull request Apr 12, 2022
@maya-r
Update builder to include kubevirt#2087, builder based on centos stream9
49a3d61 
Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Apr 20, 2022
@maya-r
Use centos:stream9 as a base image, cleanup unused code (#1983)
02e70a5 
* Retire ember LVM code, unused

(Rationale: avoid having to change more things for changing the
base image)

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Remove unreferenced files from WORKSPACE

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Switch to centos:stream9 as a base image.

It has a significantly longer support cycle than Fedora releases,
and supposedly offers vulnerability scans.

Add a tinyCore.vdi to the repo instead of generating it.
The centos qemu-img has read-only VDI support, so we can't generate
it. Generate it using my system and add to the file-host.

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Use full names for pulls from dockerhub

CentOS doesn't like short tags

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Avoid specifying checksum for CentOS images.

They expire faster than we can update checksums, this is unfortunate
but perhaps they will soon publish images at a lower rate allowing
us to keep up.

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Bump number of open file limit to avoid bazel crashes

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Update builder to include #2087, builder based on centos stream9

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Update checksums that seem wrong

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Update ovirt links: old ones were removed

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Remove unused RPMs

Noticed due to: duplicated checksum but no problem in testsuite,
lack of aarch64 equivalent.

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Put nbdkit-vddk-plugin back for amd64.

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Use quay.io instead of dockerhub.

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Install util-linux-core for /usr/sbin/blockdev

Needed after #2174

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Update nbdkit/libnbd/nginx/ovirt versions to the latest

The previous version we were using can't be fetched any more

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Generate our own CentOS stream9 image using RPMs

Now updating the dependencies can be done by running `make rpm-deps`
and committing the change, like kubevirt.

This creates a small complication that we need to run update-ca-trust
to trust root CAs. Do this on the pod, using the entrypoint to do so.

Use a single image with all the dependencies for the test tools, we
don't benefit from making them minimal and it saved some trouble in
the conversion.

Signed-off-by: Maya Rashish <mrashish@redhat.com>

* Fixup imageio test container

Run update-ca-trust and update-crypto-policies before running
ovirt-imageio, to stop error messages.

Signed-off-by: Maya Rashish <mrashish@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhenriks mhenriks mhenriks left review comments

@awels awels Awaiting requested review from awels

Assignees

@mhenriks mhenriks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maya-r @awels @alicefr @mhenriks @kubevirt-bot