Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap image used for CDI repo #1829

Closed
wants to merge 1 commit into from

Conversation

maya-r
Copy link
Contributor

@maya-r maya-r commented Jan 5, 2022

We seem to use multiple versions and I don't keep a close enough eye on all the different ways it could break, so limiting the change to CDI only.

This is needed to pick up updated docker, which allows us to run centos stream9.

Signed-off-by: Maya Rashish <mrashish@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 5, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign aglitke after the PR has been reviewed.
You can assign the PR to them by writing /assign @aglitke in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maya-r
Copy link
Contributor Author

maya-r commented Jan 5, 2022

@mhenriks when this merges we should be able to re-trigger the builder postsubmit job successfully and get a centos builder, but I am OK with putting Fedora back to avoid blocking your work.

@maya-r
Copy link
Contributor Author

maya-r commented Jan 10, 2022

cc @awels @mhenriks

@awels
Copy link
Member

awels commented Jan 10, 2022

/lgtm
@mhenriks would this affect your PR in CDI?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2022
@maya-r
Copy link
Contributor Author

maya-r commented Jan 10, 2022

it should be a no-op for CDI :)

@awels
Copy link
Member

awels commented Jan 10, 2022

Well we are releasing fedora based images with CDI, and if the builder makes centos binaries, we might have some issues.

@maya-r
Copy link
Contributor Author

maya-r commented Jan 10, 2022

This is the image we run make test-functional on, but it is a no-op because we run most of our things in the builder image (and also, because the bootstrap image is unchanged except for a newer docker and maybe a few other packages)

@awels
Copy link
Member

awels commented Jan 10, 2022

Oh this is the image used in prow to start our builder. Okay.

@maya-r
Copy link
Contributor Author

maya-r commented Jan 13, 2022

Not needed after #1616

@maya-r maya-r closed this Jan 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants