Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dell EMC and HPE to known provisioners #2710

Merged
merged 2 commits into from
May 17, 2023

Conversation

arnongilboa
Copy link
Collaborator

@arnongilboa arnongilboa commented May 10, 2023

What this PR does / why we need it:
Add StorageProfile default ClaimPropertySets (StorageCapabilities) for the provisioners.

Release note:

Add Dell EMC PowerFlex/Scale/Max/Store and HPE to known provisioners

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 10, 2023
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@arnongilboa arnongilboa changed the title Add Dell EMC PowerFlex/Scale/Max/Store to known provisioners Add Dell EMC and HPE to known provisioners May 11, 2023
Copy link
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, may be good to include the sources of this information in the PR description, especially HPE
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-fossa
network err

@arnongilboa
Copy link
Collaborator Author

Looks good, may be good to include the sources of this information in the PR description, especially HPE /lgtm

The source is @aglitke chat with the vendors CSI engineering teams :)

@awels
Copy link
Member

awels commented May 16, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@arnongilboa
Copy link
Collaborator Author

/cherrypick release-v1.56

@kubevirt-bot
Copy link
Contributor

@arnongilboa: once the present PR merges, I will cherry-pick it on top of release-v1.56 in a new PR and assign it to you.

In response to this:

/cherrypick release-v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arnongilboa
Copy link
Collaborator Author

/cherrypick release-v1.55

@kubevirt-bot
Copy link
Contributor

@arnongilboa: once the present PR merges, I will cherry-pick it on top of release-v1.55 in a new PR and assign it to you.

In response to this:

/cherrypick release-v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awels
Copy link
Member

awels commented May 16, 2023

/test pull-containerized-data-importer-e2e-istio

@arnongilboa
Copy link
Collaborator Author

/test pull-containerized-data-importer-e2e-upg

1 similar comment
@arnongilboa
Copy link
Collaborator Author

/test pull-containerized-data-importer-e2e-upg

@kubevirt-bot kubevirt-bot merged commit 84e2df6 into kubevirt:main May 17, 2023
1 check passed
@kubevirt-bot
Copy link
Contributor

@arnongilboa: new pull request created: #2716

In response to this:

/cherrypick release-v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

@arnongilboa: #2710 failed to apply on top of branch "release-v1.55":

Applying: Add Dell EMC PowerFlex/Scale/Max/Store to known provisioners
Using index info to reconstruct a base tree...
M	pkg/storagecapabilities/storagecapabilities.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/storagecapabilities/storagecapabilities.go
CONFLICT (content): Merge conflict in pkg/storagecapabilities/storagecapabilities.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add Dell EMC PowerFlex/Scale/Max/Store to known provisioners
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 17, 2023
Manual backport of kubevirt#2710

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 18, 2023
Manual backport of kubevirt#2710

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 18, 2023
Manual backport of kubevirt#2710

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 22, 2023
)

* [release-v1.56] Add Dell EMC and HPE to known provisioners

Manual backport of #2710

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

* [release-v1.56] Add Hitachi to known provisioners; cleanup

Manual backport of #2717

add aliases; remove ReadWriteOncePod
sync provisoners with main, adding:
k8s-sigs.io/nfs-subdir-external-provisioner
csi.ovirt.org

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

---------

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 24, 2023
)

* [release-v1.55] Add Dell EMC and HPE to known provisioners

Manual backport of #2710

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

* [release-v1.55] Add Hitachi to known provisioners; cleanup

Manual backport of #2717

add aliases; remove ReadWriteOncePod
sync provisoners with main, adding:
k8s-sigs.io/nfs-subdir-external-provisioner
linstor.csi.linbit.com
manila.csi.openstack.org
csi.ovirt.org

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

---------

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants