Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hitachi to known provisioners #2717

Merged
merged 1 commit into from
May 19, 2023

Conversation

arnongilboa
Copy link
Collaborator

What this PR does / why we need it:
Add StorageProfile default ClaimPropertySets (StorageCapabilities) for the provisioner.

Release note:

Add Hitachi to known provisioners

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels May 17, 2023
@arnongilboa
Copy link
Collaborator Author

/retest

@aglitke
Copy link
Member

aglitke commented May 18, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
Copy link
Member

@awels awels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we don't use RWO block as an option here if RWO is specified in the storage spec?

@aglitke
Copy link
Member

aglitke commented May 18, 2023

@awels I suppose you could add that one too.

add aliases; remove ReadWriteOncePod

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot added size/L and removed lgtm Indicates that a PR is ready to be merged. size/XS labels May 18, 2023
@awels
Copy link
Member

awels commented May 18, 2023

/approve
/lgtm
/retest-required

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@arnongilboa
Copy link
Collaborator Author

/test pull-containerized-data-importer-e2e-destructive

@kubevirt-bot kubevirt-bot merged commit 210b9db into kubevirt:main May 19, 2023
1 check passed
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 21, 2023
Manual backport of kubevirt#2717

add aliases; remove ReadWriteOncePod
sync provisoners with main, adding:
k8s-sigs.io/nfs-subdir-external-provisioner
linstor.csi.linbit.com
manila.csi.openstack.org
csi.ovirt.org

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 21, 2023
Manual backport of kubevirt#2717

add aliases; remove ReadWriteOncePod
sync provisoners with main, adding:
k8s-sigs.io/nfs-subdir-external-provisioner
csi.ovirt.org

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 22, 2023
)

* [release-v1.56] Add Dell EMC and HPE to known provisioners

Manual backport of #2710

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

* [release-v1.56] Add Hitachi to known provisioners; cleanup

Manual backport of #2717

add aliases; remove ReadWriteOncePod
sync provisoners with main, adding:
k8s-sigs.io/nfs-subdir-external-provisioner
csi.ovirt.org

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

---------

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 24, 2023
)

* [release-v1.55] Add Dell EMC and HPE to known provisioners

Manual backport of #2710

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

* [release-v1.55] Add Hitachi to known provisioners; cleanup

Manual backport of #2717

add aliases; remove ReadWriteOncePod
sync provisoners with main, adding:
k8s-sigs.io/nfs-subdir-external-provisioner
linstor.csi.linbit.com
manila.csi.openstack.org
csi.ovirt.org

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

---------

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants