Add DataImportCron snapshot sources docs #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
arnongilboa
reviewed
Jun 11, 2023
doc/os-image-poll-and-update.md
Outdated
| * VolumeSnapshot | ||
|
|
||
| DataImportCron has only maintained PVC sources for a long period of time, |
There was a problem hiding this comment.
maybe: DataImportCron was originally designed to work with PVC sources,
arnongilboa
reviewed
Jun 11, 2023
doc/os-image-poll-and-update.md
Outdated
|
|
||
| DataImportCron has only maintained PVC sources for a long period of time, | ||
| However, for certain storage types, we know that snapshots provide a better fit. |
akalenyu
force-pushed
the
doc-dataimportcron-snap-sources
branch
from
9655d2c
to
96291e3
Compare
arnongilboa
reviewed
Jun 11, 2023
doc/os-image-poll-and-update.md
Outdated
| DataImportCron has only maintained PVC sources for a long period of time, | ||
| However, for certain storage types, we know that snapshots provide a better fit. | ||
| Some examples and more info can be found in [clone-from-volumesnapshot-source](./clone-from-volumesnapshot-source.md). |
There was a problem hiding this comment.
See details and examples here
doc/os-image-poll-and-update.md
Outdated
| Some examples and more info can be found in [clone-from-volumesnapshot-source](./clone-from-volumesnapshot-source.md). | ||
|
|
||
| We keep this provisioner specific knowledge on the [StorageProfile](./storageprofile.md) object for each provisioner under `dataImportCronSourceFormat` (possible values are `snapshot`/`pvc`), which in turns signals the data import cron about which type of source is preferred for a specific provisioner. |
There was a problem hiding this comment.
We keep this provisioner-specific information in the StorageProfile of the provisioner in dataImportCronSourceFormat (possible values are snapshot/pvc), which tells the DataImportCron which type of source is preferred for the provisioner.
apinnick
reviewed
Jun 15, 2023
doc/os-image-poll-and-update.md
Outdated
| More information on image streams is available [here](https://docs.openshift.com/container-platform/4.8/openshift_images/image-streams-manage.html) and [here](https://www.tutorialworks.com/openshift-imagestreams). |
There was a problem hiding this comment.
Suggest updating this link: https://docs.openshift.com/container-platform/4.13/openshift_images/image-streams-manage.html
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
akalenyu
force-pushed
the
doc-dataimportcron-snap-sources
branch
from
96291e3
to
5719996
Compare
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
akalenyu
added a commit
to akalenyu/containerized-data-importer
that referenced
this pull request
Jul 3, 2023
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
kubevirt-bot
added a commit
that referenced
this pull request
Jul 6, 2023
* dataimportcron: Pass dynamic credential support label (#2760) * dataimportcron: code change: Use better matchers in tests Signed-off-by: Andrej Krejcir <akrejcir@redhat.com> * dataimportcron: Pass dynamic credential support label The label is passed from DataImportCron to DataVolume and DataSource. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com> --------- Signed-off-by: Andrej Krejcir <akrejcir@redhat.com> * Add DataImportCron snapshot sources docs (#2747) Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * add akalenyu as approver, some others as reviewers (#2766) Signed-off-by: Michael Henriksen <mhenriks@redhat.com> * Run `make rpm-deps` (#2741) * Run make rpm-deps Signed-off-by: Maya Rashish <mrashish@redhat.com> * Avoid overlayfs error message by using vfs driver Signed-off-by: Maya Rashish <mrashish@redhat.com> --------- Signed-off-by: Maya Rashish <mrashish@redhat.com> * Fix Destructive test lane failure - missing pod following recreate of CDI (#2744) Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * [WIP] Handle nil ptr in dataimportcron controller (#2769) Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Revert some gomega error checking that produce confusing output (#2772) One of these tests flakes, but the error is hard to debug because gomega will yell about `Unexpected non-nil/non-zero argument at index 0` Instead of showing the error. Apparently this is intended: https://github.com/onsi/gomega/pull/480/files#diff-e696deff1a5be83ad03053b772926cb325cede3b33222fa76c2bb1fcf2efd809R186-R190 Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Run bazelisk run //robots/cmd/uploader:uploader -- -workspace /home/prow/go/src/github.com/kubevirt/project-infra/../containerized-data-importer/WORKSPACE -dry-run=false (#2770) Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com> * [CI] Add metrics name linter (#2774) Signed-off-by: Aviv Litman <alitman@redhat.com> --------- Signed-off-by: Andrej Krejcir <akrejcir@redhat.com> Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Signed-off-by: Michael Henriksen <mhenriks@redhat.com> Signed-off-by: Maya Rashish <mrashish@redhat.com> Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com> Signed-off-by: Aviv Litman <alitman@redhat.com> Co-authored-by: Andrej Krejcir <akrejcir@gmail.com> Co-authored-by: Michael Henriksen <mhenriks@redhat.com> Co-authored-by: Maya Rashish <mrashish@redhat.com> Co-authored-by: kubevirt-bot <kubevirtbot@redhat.com> Co-authored-by: Aviv Litman <64130977+avlitman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: