-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition in populators so we clean up PVC' after population succeeds #2821
Conversation
Skipping CI for Draft Pull Request. |
93b32c0
to
fb497e5
Compare
fb497e5
to
8077028
Compare
… all cases This commit fixes a race condition in CDI populators so we attempt to get PVC' even if the population source doesn't exist. This new behavior allows us to correctly delete the PVC' once the population has succeeded, even if the population source doesn't exist anymore. Signed-off-by: Alvaro Romero <alromero@redhat.com>
8077028
to
73b23a3
Compare
/cc @mhenriks |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-containerized-data-importer-e2e-ceph |
1 similar comment
/test pull-containerized-data-importer-e2e-ceph |
/cherrypick release-v1.57 |
@awels: once the present PR merges, I will cherry-pick it on top of release-v1.57 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@awels: #2821 failed to apply on top of branch "release-v1.57":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This Pull Request fixes a race condition in CDI populators so we fetch the PVC' even if the population source doesn't exist.
This new behavior allows us to correctly delete the PVC' once the population has succeeded. We assume that, if PVC' already exists, all the requirements for population have already been met, so we don't need to check them all again.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # https://bugzilla.redhat.com/show_bug.cgi?id=2223361
Release note: