Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.57] Manual cherrypick of #2821 #2833

Merged

Conversation

alromeros
Copy link
Collaborator

@alromeros alromeros commented Aug 2, 2023

What this PR does / why we need it:

Manual cherry-pick of #2821 since we can't backport the multi-stage import code.

Release note:

Bugfix: Clean up PVC' when population succeeds even if the population source doesn't exist

… all cases

This commit fixes a race condition in CDI populators so we attempt to get PVC' even if the population source doesn't exist.

This new behavior allows us to correctly delete the PVC' once the population has succeeded, even if the population source doesn't exist anymore.

Signed-off-by: Alvaro Romero <alromero@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Aug 2, 2023
@awels
Copy link
Member

awels commented Aug 2, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@kubevirt-bot kubevirt-bot merged commit b7800d6 into kubevirt:release-v1.57 Aug 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants