Do not fail DV reconcile if storage class is not found #2860
Conversation
kubevirt-bot
added
release-note
arnongilboa
force-pushed
the
reconcile_sc_no_default_main
branch
from
e5b9f52
to
b1dbdc9
Compare
Manual backport of kubevirt#2860, fixing bz #2232347 Currently there is a repeating reconcile error due to exponential backoff: "DataVolume.storage spec is missing accessMode and no storageClass to choose profile", however the error is not needed as we already have SC watch for this case, e.g. when the DV is using the default SC but no default SC is configured yet. Note the SC Watch() was mistakenly looking for DVs with unset phase (like in the main/1.57 branch), but should look for Pending DVs instead. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
|
/lgtm |
|
@awels: once the present PR merges, I will cherry-pick it on top of release-v1.57 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
@akalenyu I think a utest verifying reconcile does not return error in this case is wiser here. wdyt? |
Yep that works |
arnongilboa
force-pushed
the
reconcile_sc_no_default_main
branch
from
b1dbdc9
to
b5277e9
Compare
kubevirt-bot
added
size/M
and removed
lgtm
Manual backport of kubevirt#2860, fixing bz #2232347 Currently there is a repeating reconcile error due to exponential backoff: "DataVolume.storage spec is missing accessMode and no storageClass to choose profile", however the error is not needed as we already have SC watch for this case, e.g. when the DV is using the default SC but no default SC is configured yet. Note the SC Watch() was mistakenly looking for DVs with unset phase (like in the main/1.57 branch), but should look for Pending DVs instead. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
|
|
||
| reconciler = createImportReconciler(importDataVolume) | ||
| _, err := reconciler.Reconcile(context.TODO(), reconcile.Request{NamespacedName: types.NamespacedName{Name: "test-dv", Namespace: metav1.NamespaceDefault}}) | ||
| Expect(err).ToNot(HaveOccurred()) |
There was a problem hiding this comment.
Maybe also
Expect(result).To(Equal(reconcile.Result{}))
To ensure requeue/requeueafter don't get set?
Manual backport of kubevirt#2860, fixing bz #2232347 Currently there is a repeating reconcile error due to exponential backoff: "DataVolume.storage spec is missing accessMode and no storageClass to choose profile", however the error is not needed as we already have SC watch for this case, e.g. when the DV is using the default SC but no default SC is configured yet. Note the SC Watch() was mistakenly looking for DVs with unset phase (like in the main/1.57 branch), but should look for Pending DVs instead. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Currently there is a repeating reconcile error due to exponential backoff: "DataVolume.storage spec is missing accessMode and no storageClass to choose profile", however the error is not needed as we already have SC watch for this case, e.g. when the DV is using the default SC but no default SC is configured yet. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
reconcile_sc_no_default_main
branch
from
b5277e9
to
c066981
Compare
|
/lgtm |
|
@akalenyu: once the present PR merges, I will cherry-pick it on top of release-v1.57 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubevirt-bot
removed
the
do-not-merge/hold
#2861) Manual backport of #2860, fixing bz #2232347 Currently there is a repeating reconcile error due to exponential backoff: "DataVolume.storage spec is missing accessMode and no storageClass to choose profile", however the error is not needed as we already have SC watch for this case, e.g. when the DV is using the default SC but no default SC is configured yet. Note the SC Watch() was mistakenly looking for DVs with unset phase (like in the main/1.57 branch), but should look for Pending DVs instead. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
|
@awels: new pull request created: #2869 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Currently there is a repeating reconcile error due to exponential backoff:
DataVolume.storage spec is missing accessMode and no storageClass to choose profile, however the error is not needed as we already haveStorageClasswatch for this case, e.g. when theDataVolumeis using the defaultStorageClassbut no defaultStorageClassis configured yet.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: