[release-v1.56] Do not fail DV reconcile if storage class is not found #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/hold main is not merged yet. |
kubevirt-bot
added
the
do-not-merge/hold
arnongilboa
force-pushed
the
reconcile_sc_no_default-v1.56
branch
from
19d1c63
to
8c09888
Compare
kubevirt-bot
added
size/M
and removed
lgtm
Manual backport of kubevirt#2860, fixing bz #2232347 Currently there is a repeating reconcile error due to exponential backoff: "DataVolume.storage spec is missing accessMode and no storageClass to choose profile", however the error is not needed as we already have SC watch for this case, e.g. when the DV is using the default SC but no default SC is configured yet. Note the SC Watch() was mistakenly looking for DVs with unset phase (like in the main/1.57 branch), but should look for Pending DVs instead. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
reconcile_sc_no_default-v1.56
branch
from
8c09888
to
5b560b3
Compare
|
/lgtm |
kubevirt-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Manual backport of #2860
Currently there is a repeating reconcile error due to exponential backoff:
DataVolume.storage spec is missing accessMode and no storageClass to choose profile, however the error is not needed as we already haveStorageClasswatch for this case, e.g. when theDataVolumeis using the defaultStorageClassbut no defaultStorageClassis configured yet.Note the SC Watch() was mistakenly looking for DVs with unset phase (like in the main/1.57 branch), but should look for Pending DVs instead.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes bz #2232347
Special notes for your reviewer:
Release note: