Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.58] Add new Prometheus alerts and label existing alerts #3040

Merged
merged 1 commit into from
Dec 26, 2023

Commits on Dec 25, 2023

  1. [release-v1.58] Add new Prometheus alerts and label existing alerts

    Manual backport of kubevirt#2998 & kubevirt#3038
    
    - CDINoDefaultStorageClass - not having a default (or virt default)
    SC is surely not an OpenShift error, as admins may prefer their cluster
    users to only use explicit SC names. However, in the CDI context when
    DV is created with default SC but default does not exist, we will fire
    an error event and the PVC will be Pending for the default SC, so when
    there are such Pending PVCs we will fire an alert.
    
    - CDIDefaultStorageClassDegraded - when the default (or virt default)
    SC does not support CSI/Snapshot clone (smart clone) or does not have
    ReadWriteMany access mode (for live migration).
    
    - CDIStorageProfilesIncomplete - add storageClass and provisioner
    labels.
    
    - CDIDataImportCronOutdated - add dataImportCron namespace and name
    labels.
    
    Also:
    * Rename the metric kubevirt_cdi_storageprofile_status to
    kubevirt_cdi_storageprofile_info since it always reports value 1,
    where the label values provide the details about the storage class and
    storage profile.
    * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp
    destructive lane
    
    Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
    arnongilboa committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    b1a295e View commit details
    Browse the repository at this point in the history