update to k8s 1.30 libs and controller-runtime 0.18.4

[mhenriks]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1097

Special notes for your reviewer:

Release note:

k8s 1.30 libs and controller-runtime 0.18.4

[mhenriks]

/hold

Until this is not pointing to my github

[akalenyu]

/retest

[akalenyu]

@awels I think something's up with FOSSA here

[mhenriks]

/unhold

[akalenyu]

/approve
/cc @awels
FOSSA is lying I think

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [akalenyu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[awels]

Hmmm so it is complaining about a dependency in vendor/github.com/hashicorp/golang-lru being MPL 2.0. Which is not compatible with our licenses. It is being vendor-ed in through github.com/openshift/library-go
I think we should avoid anything hashicorp as much as possible.

[akalenyu]

Hmmm so it is complaining about a depedency in vendor/github.com/hashicorp/golang-lru being MPL 2.0. Which is not compatible with our licenses. It is being vendor-ed in through github.com/openshift/library-go I think we should avoid anything hashicorp as much as possible.

right.. I see it's coming from their dep. on distribution/distribution in helpers we are not using:
openshift/library-go@01526ee
anyway, I wonder how other library-go consumers are not finding this problem

[mhenriks]

@awels golang-lru code is not in vendor directory so we are not actually directly or indirectly using it. Are there exceptions for this?

[awels]

I can mark it as an exception indicating it is not being used at all. I wonder why it was flagged. You are right that it is not being vendored at all.

[awels]

/test pull-containerized-data-importer-fossa

[awels]

/test pull-containerized-data-importer-fossa

[awels]

/lgtm

[akalenyu]

/test pull-containerized-data-importer-e2e-upg

[akalenyu]

I think this failure is about doing a rebind when pod is still running?
"cdi.kubevirt.io/storage.pod.phase": "Running",
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_containerized-data-importer/3336/pull-containerized-data-importer-e2e-upg/1811766743761162240

[akalenyu]

/test pull-containerized-data-importer-e2e-nfs
Error: failed get datavolume: test-dv, client rate limiter Wait returned an error: context deadline exceeded