-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using fork of openshift/library-go #1097
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
/lifecycle frozen |
This still applies right @mhenriks |
@mhenriks please take a look and see if we can make the needed methods public in openshift/library-go#540 |
created openshift/library-go#1486 |
Just lgtmed, hope we can merge it soon. |
Closing this since it's been addressed by openshift/library-go@434fa21. Feel free to reopen if necessary. |
/reopen |
@akalenyu: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
thanks for the reminder @akalenyu |
Unfortunately have to wait until we move to k8s 1.29 (release-4.16+ branch in library-go) to do this |
Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
#1091 references a fork of openshift/library-go
Once the following PR is merged, CDI should go back the mainline:
openshift/library-go#540
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
kubectl get deployments cdi-deployment -o yaml
):kubectl version
):The text was updated successfully, but these errors were encountered: