-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/certrotation: make rotation methods public #540
Conversation
They're useful outside of the static-pod operators.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: squeed The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hey @deads2k could you take a quick look at this? |
This is probably not needed. Hold please, will close if so. |
+1 |
@@ -30,7 +30,7 @@ type SigningRotation struct { | |||
EventRecorder events.Recorder | |||
} | |||
|
|||
func (c SigningRotation) ensureSigningCertKeyPair() (*crypto.CA, error) { | |||
func (c SigningRotation) EnsureSigningCertKeyPair() (*crypto.CA, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does it do. Public methods need docs.
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
They're useful outside of the static-pod operators.