Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in the deploy/deploy.sh script #2673

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Fix bug in the deploy/deploy.sh script #2673

merged 2 commits into from
Dec 10, 2023

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Dec 10, 2023 •
edited

What this PR does / why we need it

The current script lacks the applying of the MTQ CRD, causing the HCO deployment to fail, and the HCO pod to exit with error.

This PR adds the missing CRD.

Also, make sync is broken because kubevirtci started use crictl instead of podman. This PR changes the cli to crictl in hack/sync.sh.

Fixes #2672

Reviewer Checklist

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket

None

Release note

Fix bug in deploy/deploy.sh script. Add missing CRD.

@nunnatsa
Fix bug in the deploy/deploy.sh script
44af83f 
The current script lacks the applying of the MTQ CRD, causing the HCO
deployment to fail, and the HCO pod to exit with error.

This PR adds the missing CRD.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 10, 2023
@nunnatsa
Copy link
Collaborator Author

/cherry-pick release-1.10

@kubevirt-bot
Copy link
Contributor

@nunnatsa: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link
Collaborator

coveralls commented Dec 10, 2023 •
edited

Pull Request Test Coverage Report for Build 7157529594

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.436%
Totals Coverage Status
Change from base Build 7129058529: 0.02%
Covered Lines: 5289
Relevant Lines: 6119
💛 - Coveralls

@nunnatsa
Copy link
Collaborator Author

/retest

1 similar comment
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa
Fix the cluster/sync.sh script
cf87a07 
kubevirtci moved to use `crictl` over `podman`. Modify the script to
refluct that.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Copy link
Collaborator Author

/retest

orenc1
orenc1 approved these changes Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@orenc1 orenc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2023
@kubevirt-bot kubevirt-bot merged commit 8d311f7 into kubevirt:main Dec 10, 2023
12 checks passed
@kubevirt-bot kubevirt-bot mentioned this pull request Dec 10, 2023
Merged
@kubevirt-bot
Copy link
Contributor

@nunnatsa: new pull request created: #2674

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa nunnatsa deleted the fix-2672 branch December 10, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 orenc1 approved these changes

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

Assignees

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't deploy hyper-converged using the deploy/deploy.sh script
4 participants
@nunnatsa @kubevirt-bot @coveralls @orenc1