Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.10] Fix bug in the deploy/deploy.sh script #2674

Merged
merged 2 commits into from
Dec 10, 2023
Merged

[release-1.10] Fix bug in the deploy/deploy.sh script #2674

merged 2 commits into from
Dec 10, 2023

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #2673

/assign nunnatsa

Fix bug in deploy/deploy.sh script. Add missing CRD.

@nunnatsa
Fix bug in the deploy/deploy.sh script
022f829 
The current script lacks the applying of the MTQ CRD, causing the HCO
deployment to fail, and the HCO pod to exit with error.

This PR adds the missing CRD.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Fix the cluster/sync.sh script
073eec2 
kubevirtci moved to use `crictl` over `podman`. Modify the script to
refluct that.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Dec 10, 2023
Merged
11 tasks
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 10, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7159640904

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.184%
Totals Coverage Status
Change from base Build 7115956116: 0.02%
Covered Lines: 5240
Relevant Lines: 6080
💛 - Coveralls

@nunnatsa
Copy link
Collaborator

/retest

@nunnatsa
Copy link
Collaborator

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2023
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2023
@kubevirt-bot kubevirt-bot merged commit 2527945 into kubevirt:release-1.10 Dec 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@sradco sradco Awaiting requested review from sradco

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubevirt-bot @coveralls @nunnatsa