Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Jest 25 v2 #1355

Merged
merged 11 commits into from
Jan 23, 2020
Merged

feat: support Jest 25 v2 #1355

merged 11 commits into from
Jan 23, 2020

Conversation

kibertoad
Copy link

@kibertoad kibertoad commented Jan 22, 2020

Based on #1232
fixes #1354

haoqunjiang and others added 6 commits September 17, 2019 22:02
…st25

� Conflicts:
�	e2e/__templates__/default/package-lock.json
�	e2e/__templates__/default/package.json
�	e2e/__templates__/with-babel-7/package-lock.json
�	e2e/__templates__/with-babel-7/package.json
�	e2e/__templates__/with-typescript-2-7/package-lock.json
�	e2e/__templates__/with-typescript-2-7/package.json
�	e2e/__templates__/with-unsupported-version/package-lock.json
�	e2e/__templates__/with-unsupported-version/package.json
�	package-lock.json
@kibertoad kibertoad mentioned this pull request Jan 22, 2020
@kibertoad
Copy link
Author

@kulshekhar Any ideas why deep-path.test.ts would be failing?

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jan 22, 2020

hi @kibertoad , would you please also including update e2e template into this PR ? You can use command update:e2e found in package.json.

updated Sorry my bad I saw e2e templates were included already.

@kulshekhar
Copy link
Owner

@kibertoad I'm not sure. I'll take a look once the CI run is done to see if there's anything I can identify offhand

@kulshekhar
Copy link
Owner

@kibertoad I think, in the failing tests, the snapshots just have to be regenerated

@coveralls
Copy link

coveralls commented Jan 22, 2020

Pull Request Test Coverage Report for Build 3889

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.286%

Totals Coverage Status
Change from base Build 3881: 0.0%
Covered Lines: 1075
Relevant Lines: 1133

💛 - Coveralls

@kibertoad
Copy link
Author

@kulshekhar It's green now!

package.json Outdated
@@ -69,7 +70,7 @@
"yargs-parser": "10.x"
},
"peerDependencies": {
"jest": ">=24 <25"
"jest": ">=24 <26"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to ">=25 <26"

TypeScript = '>=2.7 <4',
BabelJest = '>=24 <25',
BabelJest = '>=24 <26',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to ">=25 <26"

@@ -10,9 +10,9 @@ const logger = rootLogger.child({ namespace: 'versions' })
* @internal
*/
export enum ExpectedVersions {
Jest = '>=24 <25',
Jest = '>=24 <26',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to ">=25 <26"

@kulshekhar
Copy link
Owner

@kibertoad thanks! Just added a request for a few minor changes

@kibertoad
Copy link
Author

@kulshekhar Addressed!

@kibertoad
Copy link
Author

@kulshekhar Aaaaand it's green again.

Copy link
Owner

@kulshekhar kulshekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibertoad @sodatea thanks for your work! I'll have a release out shortly

@kulshekhar kulshekhar merged commit cda6519 into kulshekhar:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support jest 25.1.0
5 participants