-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Jest 25 #1232
feat: support Jest 25 #1232
Conversation
Pull Request Test Coverage Report for Build 3572
💛 - Coveralls |
Jest has released version 25 under the `next` dist-tag: - https://www.npmjs.com/package/jest/v/25.0.0 - jestjs/jest#8862 See breaking changes at https://github.com/facebook/jest/blob/6c0a16ab2f88ea645c04880a5491b3a8c2dfc66b/CHANGELOG.md The maintainer promised no more user facing breaking changes planned jestjs/jest#8956 (comment) Considering Vue CLI does not bump the major version often, we need to use the latest possible version. Currently there will be warnings from ts-jest. Once this PR gets merged kulshekhar/ts-jest#1232 the warnings will be eliminated.
@sodatea thank you for the PR. Some points that came to mind while reviewing:
I'll be happy to review this again if/once the PR is updated to address these points! |
@kulshekhar do you know when new version will be released? |
@armano2 isn't the latest stable jest version still 24.9.0? |
@kulshekhar yes jest v24.9.0 is latest |
@armano2 we (all collaborators here) typically only add support for stable releases. It'll be hard to track & address issues in |
don't worry, i'm just asking, we are not in a rush 👍 different tooling packages have different policies when/if they add support for never version, now i know that we should wait for stable release :) |
Hi, 25.1.0 is stable release now. Could you please prioritize releasing ts-jest with the support of it? |
@dmarcautan I'm going to be unable to resolve the conflicts (or send a new PR with the update) for the next few days at least. If someone else does it by then, I'll review and merge it in and publish the new version. If not, I'll try to do it over the coming weekend |
@kulshekhar Resolved conflicts in #1355 |
Jest has released version 25 under the
next
dist-tag:The maintainer promised no more user facing breaking changes planned
jestjs/jest#8956 (comment)
I've tested the new version in my local branch and figured out only these files need to be updated to support Jest 25 (Not sure if the updated tests should be included in this PR):
peerDependencies
version range to include v25ExpectedVersions
to allow new versionsasync
describe
blocks in the tests to eliminate warnings from Warn if describe returns a value jestjs/jest#7852