Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Jest 25 #1232

Merged
merged 4 commits into from
Jan 23, 2020
Merged

feat: support Jest 25 #1232

merged 4 commits into from
Jan 23, 2020

Conversation

haoqunjiang
Copy link
Contributor

@haoqunjiang haoqunjiang commented Sep 17, 2019

Jest has released version 25 under the next dist-tag:

The maintainer promised no more user facing breaking changes planned
jestjs/jest#8956 (comment)

I've tested the new version in my local branch and figured out only these files need to be updated to support Jest 25 (Not sure if the updated tests should be included in this PR):

@coveralls
Copy link

coveralls commented Sep 17, 2019

Pull Request Test Coverage Report for Build 3572

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.049%

Totals Coverage Status
Change from base Build 3571: 0.0%
Covered Lines: 1071
Relevant Lines: 1131

💛 - Coveralls

haoqunjiang added a commit to haoqunjiang/vue-cli that referenced this pull request Sep 17, 2019
Jest has released version 25 under the `next` dist-tag:
- https://www.npmjs.com/package/jest/v/25.0.0
- jestjs/jest#8862

See breaking changes at
https://github.com/facebook/jest/blob/6c0a16ab2f88ea645c04880a5491b3a8c2dfc66b/CHANGELOG.md

The maintainer promised no more user facing breaking changes planned
jestjs/jest#8956 (comment)

Considering Vue CLI does not bump the major version often, we need to
use the latest possible version.

Currently there will be warnings from ts-jest.
Once this PR gets merged kulshekhar/ts-jest#1232
the warnings will be eliminated.
@kulshekhar
Copy link
Owner

@sodatea thank you for the PR. Some points that came to mind while reviewing:

  • we typically only support the Jest version in the same major range. For example, ts-jest v24.x.x will only support jest v24.

  • the PR doesn't have the updated package-lock.json file

  • the package.json (and lock file) for some tests will also need to be updated with this jest version

I'll be happy to review this again if/once the PR is updated to address these points!

@armano2
Copy link
Contributor

armano2 commented Dec 30, 2019

@kulshekhar do you know when new version will be released?

@kulshekhar
Copy link
Owner

@armano2 isn't the latest stable jest version still 24.9.0?

@armano2
Copy link
Contributor

armano2 commented Jan 2, 2020

@kulshekhar yes jest v24.9.0 is latest stable version, v25 is marked as next

@kulshekhar
Copy link
Owner

@armano2 we (all collaborators here) typically only add support for stable releases. It'll be hard to track & address issues in next given the limited amount of time we can collectively spend

@armano2
Copy link
Contributor

armano2 commented Jan 2, 2020

don't worry, i'm just asking, we are not in a rush 👍


different tooling packages have different policies when/if they add support for never version, now i know that we should wait for stable release :)

@dmarcautan
Copy link

Hi, 25.1.0 is stable release now. Could you please prioritize releasing ts-jest with the support of it?

@kulshekhar
Copy link
Owner

@dmarcautan I'm going to be unable to resolve the conflicts (or send a new PR with the update) for the next few days at least. If someone else does it by then, I'll review and merge it in and publish the new version. If not, I'll try to do it over the coming weekend

@kibertoad
Copy link

@kulshekhar Resolved conflicts in #1355

@kulshekhar kulshekhar merged commit 111b305 into kulshekhar:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants