Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest 25 - any more breaking changes planned? #8956

Closed
haoqunjiang opened this issue Sep 16, 2019 · 4 comments
Closed

Jest 25 - any more breaking changes planned? #8956

haoqunjiang opened this issue Sep 16, 2019 · 4 comments

Comments

@haoqunjiang
Copy link

I noticed that a 25.0.0 version published in the npm registry under the next dist-tag.
It does not have an alpha or beta suffix.
So I'm wondering: will there be any more breaking changes in the subsequent 25.x releases other than the currently listed ones in the changelog? Because if so, that seems to be a breach of semver.

@haoqunjiang
Copy link
Author

haoqunjiang commented Sep 16, 2019

I raise this issue because I'm working on Vue CLI and we are very close to release a new major version.
I'm not sure whether should I bundle it with Jest 24 or 25 - neither seems a good idea at the moment.

@SimenB
Copy link
Member

SimenB commented Sep 16, 2019

There are no more planned user facing breaking changes (meaning we might tweak some internal stuff in a technically non-breaking way, but that shouldn't affect users).

A new release should be just around the corner, things are taking a bit longer than anticipated.


I'll close this as it's not really actionable, but feel free to keep the discussion going 🙂

@SimenB SimenB closed this as completed Sep 16, 2019
@haoqunjiang
Copy link
Author

Thanks for the quick response!
Then I think I'll just go with Jest 25.

haoqunjiang added a commit to haoqunjiang/vue-cli that referenced this issue Sep 17, 2019
Jest has released version 25 under the `next` dist-tag:
- https://www.npmjs.com/package/jest/v/25.0.0
- jestjs/jest#8862

See breaking changes at
https://github.com/facebook/jest/blob/6c0a16ab2f88ea645c04880a5491b3a8c2dfc66b/CHANGELOG.md

The maintainer promised no more user facing breaking changes planned
jestjs/jest#8956 (comment)

Considering Vue CLI does not bump the major version often, we need to
use the latest possible version.

Currently there will be warnings from ts-jest.
Once this PR gets merged kulshekhar/ts-jest#1232
the warnings will be eliminated.
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants