Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to jest 25 #4585

Closed
wants to merge 2 commits into from
Closed

feat!: update to jest 25 #4585

wants to merge 2 commits into from

Conversation

haoqunjiang
Copy link
Member

@haoqunjiang haoqunjiang commented Sep 17, 2019

Jest has released version 25 under the next dist-tag:

See breaking changes at
https://github.com/facebook/jest/blob/6c0a16ab2f88ea645c04880a5491b3a8c2dfc66b/CHANGELOG.md

The maintainer promised no more user facing breaking changes planned
jestjs/jest#8956 (comment)

Considering Vue CLI does not bump the major version often, we need to
use the latest possible version.

Currently there will be warnings from ts-jest.
Once this PR gets merged kulshekhar/ts-jest#1232
the warnings will be eliminated.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Jest has released version 25 under the `next` dist-tag:
- https://www.npmjs.com/package/jest/v/25.0.0
- jestjs/jest#8862

See breaking changes at
https://github.com/facebook/jest/blob/6c0a16ab2f88ea645c04880a5491b3a8c2dfc66b/CHANGELOG.md

The maintainer promised no more user facing breaking changes planned
jestjs/jest#8956 (comment)

Considering Vue CLI does not bump the major version often, we need to
use the latest possible version.

Currently there will be warnings from ts-jest.
Once this PR gets merged kulshekhar/ts-jest#1232
the warnings will be eliminated.
@haoqunjiang
Copy link
Member Author

I just realized that the upgrade path to Jest 25 could be very smooth and non-breaking. Because the only major user-facing change in Jest 25 is the upgrading of jsdom (v11 -> v15). If we preconfigured it in our presets (#4597), then later we can directly upgrade Jest to 25 without affecting users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant