Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade k3d #5518

Merged
merged 3 commits into from
Dec 19, 2022
Merged

chore(deps): upgrade k3d #5518

merged 3 commits into from
Dec 19, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Dec 16, 2022

K3d has an issue k3d-io/k3d#1020 that sometimes imports fails with docker error.

INFO[0005] Importing images '[kumahq/kuma-dp:0.0.0-preview.vef15bc18d kumahq/kuma-universal:0.0.0-preview.vef15bc18d]' into node 'k3d-kuma-1-server-0'... 
INFO[0005] Importing images '[kumahq/kuma-dp:0.0.0-preview.vef15bc18d kumahq/kuma-universal:0.0.0-preview.vef15bc18d]' into node 'k3d-second-ql9r4w-0'... 
ERRO[0005] Failed to copy read stream. write unix @->/run/docker.sock: use of closed network connection

It has been fixed in 5.4.1

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lukidzi
chore(deps): upgrade k3d
4801429 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Dec 16, 2022
@lukidzi lukidzi requested review from a team, lahabana and jakubdyszkiewicz and removed request for a team December 16, 2022 13:46
@jakubdyszkiewicz
Copy link
Contributor

do we need to change deps.lock?

@lukidzi
Copy link
Contributor Author

lukidzi commented Dec 16, 2022

do we need to change deps.lock?

Probably yes, gonna fix it

@lukidzi
chore(deps): update lock
a9cd913 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi merged commit c6dbfa4 into kumahq:master Dec 19, 2022
@jakubdyszkiewicz jakubdyszkiewicz mentioned this pull request Jan 19, 2023
Merged
12 tasks
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lahabana lahabana Awaiting requested review from lahabana

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukidzi @jakubdyszkiewicz @michaelbeaumont