chore: use direct mode to import images in k3d #5770
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two modes of importing images in K3D, "direct" and "node-tools".
Because "direct" mode was not reliable enough, K3D team switched back to "node-tools" by default in K3D 5.4.0 that we recently upgraded to. The problem is that "node-tools" also can fail and in a worse way because it returns exit code 0, so we cannot retry. See k3d-io/k3d#1072
Our CI is really flaky recently because of this. Here is an example.
This PR switches image import to "direct" once again, but with more retries.
We already use direct mode here.
What might be a problem is that this command may be stuck, see #5667 . If this will be the case "outside of executing from Go" we can add a similar timeout in Makefiles.
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?