Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use direct mode to import images in k3d #5770

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

There are two modes of importing images in K3D, "direct" and "node-tools".

Because "direct" mode was not reliable enough, K3D team switched back to "node-tools" by default in K3D 5.4.0 that we recently upgraded to. The problem is that "node-tools" also can fail and in a worse way because it returns exit code 0, so we cannot retry. See k3d-io/k3d#1072

Our CI is really flaky recently because of this. Here is an example.

This PR switches image import to "direct" once again, but with more retries.

We already use direct mode here.
What might be a problem is that this command may be stuck, see #5667 . If this will be the case "outside of executing from Go" we can add a similar timeout in Makefiles.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, Automaat and lukidzi and removed request for a team January 19, 2023 13:14
mk/k3d.mk Outdated Show resolved Hide resolved
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) January 19, 2023 13:30
@jakubdyszkiewicz jakubdyszkiewicz merged commit c9f6a64 into kumahq:master Jan 19, 2023
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/k3d-import-fails branch January 19, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants