Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ginkgo): use newer ginkgo with better output #9603

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

lahabana
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana
Copy link
Contributor Author

Experimenting to see if onsi/ginkgo#1373 improves the readability of our output

@lahabana lahabana changed the title ci(ginkgo): try to use newer ginkgo with better output ci(ginkgo): use newer ginkgo with better output Mar 20, 2024
@lahabana lahabana force-pushed the useAltGinkgo branch 2 times, most recently from 058646b to ef15086 Compare March 20, 2024 09:24
This should make output easier to read

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana marked this pull request as ready for review March 20, 2024 09:25
@lahabana lahabana requested a review from a team as a code owner March 20, 2024 09:25
@lahabana lahabana requested review from jijiechen, jakubdyszkiewicz and bartsmykla and removed request for a team March 20, 2024 09:25
@lahabana lahabana merged commit 1a83212 into kumahq:master Mar 20, 2024
15 checks passed
@lahabana lahabana deleted the useAltGinkgo branch March 29, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants