add --github-output for nicer output in github actions
#1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverage github's special formats to output nicer output https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions Fix onsi#1372 Signed-off-by: Charly Molter <charly.molter@konghq.com>
|
@onsi putting that in draft I still need to validate a few things but that's the rough idea for the change |
|
hey that looks great. the tests for the reporter are a bit long/verbose but will you be adding one as well? also can you update Ginkgo's own test.yml to use the feature? Thanks! |
Signed-off-by: Charly Molter <charly.molter@konghq.com>
|
@onsi I added 1 test (they are indeed quite tricky to write...) let me know if you want more tests |
|
hey thanks. no the one is good - just want to make sure future work doesn't break this feature. |
5 tasks
|
Ok I'll undraft this once I've checked the output in: kumahq/kuma#9603 looks good |
|
@onsi I think it's ready! |
|
great! i’ll merge it in when CI finishes and will cut a release soon. |
|
done! thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage github's special formats to output nicer output
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions
Fix #1372