-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --github-output
for nicer output in github actions
#1373
Conversation
Leverage github's special formats to output nicer output https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions Fix onsi#1372 Signed-off-by: Charly Molter <charly.molter@konghq.com>
@onsi putting that in draft I still need to validate a few things but that's the rough idea for the change |
hey that looks great. the tests for the reporter are a bit long/verbose but will you be adding one as well? also can you update Ginkgo's own test.yml to use the feature? Thanks! |
Signed-off-by: Charly Molter <charly.molter@konghq.com>
@onsi I added 1 test (they are indeed quite tricky to write...) let me know if you want more tests |
hey thanks. no the one is good - just want to make sure future work doesn't break this feature. |
Ok I'll undraft this once I've checked the output in: kumahq/kuma#9603 looks good |
@onsi I think it's ready! |
great! i’ll merge it in when CI finishes and will cut a release soon. |
done! thank you :) |
Leverage github's special formats to output nicer output
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions
Fix #1372