init fleet api to install flagger and testloader #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hzxuzhonghu
reviewed
Dec 18, 2023
| @@ -507,6 +507,32 @@ type Device struct { | |||
| Config map[string]string `json:"config,omitempty"` | |||
| } | |||
|
|
|||
| type FlaggerConfig struct { | |||
There was a problem hiding this comment.
I think you forget to add it to plugin
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
plugin-flagger-api
branch
from
f54809c to
70e6ea9
Compare
hzxuzhonghu
reviewed
Dec 19, 2023
pkg/apis/fleet/v1alpha1/types.go
Outdated
| @@ -507,6 +509,32 @@ type Device struct { | |||
| Config map[string]string `json:"config,omitempty"` | |||
| } | |||
|
|
|||
| type FlaggerConfig struct { | |||
| // Chart defines the helm chart config of the flagger. | |||
| // default values is | |||
There was a problem hiding this comment.
Suggested change
| // default values is | |
| // default value is |
hzxuzhonghu
reviewed
Dec 19, 2023
| // Chart defines the helm chart config of the flagger. | ||
| // default values is | ||
| // | ||
| // chart: |
LiZhenCheng9527
force-pushed
the
plugin-flagger-api
branch
from
8c00330 to
7c53d1d
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
plugin-flagger-api
branch
from
3284553 to
696bb98
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
Add configuretion to install flagger in fleet api.