-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init fleet api to install flagger and testloader #519
Merged
kurator-bot
merged 2 commits into
kurator-dev:main
from
LiZhenCheng9527:plugin-flagger-api
Dec 19, 2023
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -85,6 +85,8 @@ type PluginConfig struct { | |||||
Backup *BackupConfig `json:"backup,omitempty"` | ||||||
// DistributedStorage define the configuration for the distributed storage(Implemented with Rook) | ||||||
DistributedStorage *DistributedStorageConfig `json:"distributedStorage,omitempty"` | ||||||
// Flagger defines the configuretion for the kurator rollout engine. | ||||||
Flagger *FlaggerConfig `json:"flagger,omitempty"` | ||||||
} | ||||||
|
||||||
type MetricConfig struct { | ||||||
|
@@ -507,6 +509,32 @@ type Device struct { | |||||
Config map[string]string `json:"config,omitempty"` | ||||||
} | ||||||
|
||||||
type FlaggerConfig struct { | ||||||
// Chart defines the helm chart config of the flagger. | ||||||
// default values is | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
// | ||||||
// chart: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wrap with
|
||||||
// repository: oci://ghcr.io/fluxcd/charts | ||||||
// name: flagger | ||||||
// version: 1.x | ||||||
// | ||||||
// +optional | ||||||
Chart *ChartConfig `json:"chart,omitempty"` | ||||||
// ExtraArgs is the set of extra arguments for flagger chart. | ||||||
// | ||||||
// For Example, using following configuration to change replica count. | ||||||
// extraArgs: | ||||||
// flagger: | ||||||
// replicaCount: 2 | ||||||
// | ||||||
// +optional | ||||||
ExtraArgs apiextensionsv1.JSON `json:"extraArgs,omitempty"` | ||||||
// PublicTestloader defines whether to install the publictestloader or not. | ||||||
// In addition to the public testloader you can configure here, | ||||||
// you can also specify a private testloader in the Application.Spec.SyncPolicies.Rollout.TestLoader | ||||||
PublicTestloader bool `json:"publicTestloader,omitempty"` | ||||||
} | ||||||
|
||||||
// FleetStatus defines the observed state of the fleet | ||||||
type FleetStatus struct { | ||||||
// CredentialSecret is the secret name that holds credentials used for accessing the fleet control plane. | ||||||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forget to add it to plugin