Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NATS manager. #25

Merged
merged 16 commits into from
Apr 12, 2023
Merged

Implement NATS manager. #25

merged 16 commits into from
Apr 12, 2023

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Apr 4, 2023 •
edited

Description

Changes proposed in this pull request:

  • More worked out versions of the NATS manager API

Related issue(s)

@friedrichwilken friedrichwilken requested a review from a team as a code owner April 4, 2023 08:20
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 4, 2023
@friedrichwilken friedrichwilken changed the title Change spelling from Nats to NATS in nats_types.go. Implement NATS manager. Apr 4, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2023
@friedrichwilken friedrichwilken linked an issue Apr 5, 2023 that may be closed by this pull request
Initial CRD handling #9
Closed
9 tasks
@mfaizanse mfaizanse mentioned this pull request Apr 11, 2023
Closed
9 tasks
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 12, 2023
@kyma-bot kyma-bot merged commit 4cea964 into kyma-project:main Apr 12, 2023
@friedrichwilken friedrichwilken deleted the Implement-NATS-mgr-crd branch December 19, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

Assignees

@mfaizanse mfaizanse

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial CRD handling
3 participants
@friedrichwilken @mfaizanse @kyma-bot