Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial CRD handling #9

Closed
9 tasks done
Tracked by #8
k15r opened this issue Mar 20, 2023 · 5 comments · Fixed by #25, #55, #60, #61 or #64
Closed
9 tasks done
Tracked by #8

Initial CRD handling #9

k15r opened this issue Mar 20, 2023 · 5 comments · Fixed by #25, #55, #60, #61 or #64
Assignees
Labels
area/eventing Issues or PRs related to eventing

Comments

@k15r
Copy link
Contributor

k15r commented Mar 20, 2023

Implement as two independent PRs:

  • Implement NATS CRD based on design proposal

  • Implement Validation

    • test if CEL-Validation is available in k8s v1.25
      - [ ] if not, use Admission control webhook (validating webhook)
      • if yes, use CEL-Validation
    • add validation of memSorage: dont allow enable=10 if size=0 and vice versa
    • add validation of fileStorage: make immutable if once set
    • add validation for cluster.size to only accept numbers odd numbers > 0
  • Implement defaulting

  • talk to team; what about the validation of resources for SLA compliance?

followup: #68

@k15r k15r mentioned this issue Mar 20, 2023
14 tasks
@k15r k15r changed the title Preparation Initial CRD handling Mar 20, 2023
@friedrichwilken friedrichwilken self-assigned this Mar 20, 2023
@friedrichwilken friedrichwilken linked a pull request Apr 5, 2023 that will close this issue
@mfaizanse
Copy link
Member

@friedrichwilken Does this PR cover the 2nd AC Admission control webhook (validating webhook)?

@friedrichwilken
Copy link
Contributor

@mfaizanse no, as the original task says: Implement as two independent PRs,
there will be a second PR for that (that I am working on right now.)

@mfaizanse mfaizanse reopened this Apr 12, 2023
@mfaizanse mfaizanse removed their assignment Apr 12, 2023
@k15r
Copy link
Contributor Author

k15r commented Apr 17, 2023

Blocked until checked if validation rules can be used

@mfaizanse mfaizanse added the area/eventing Issues or PRs related to eventing label Apr 21, 2023
@friedrichwilken friedrichwilken removed their assignment Apr 25, 2023
@friedrichwilken
Copy link
Contributor

To unblock this, check if validation rules can be used in gardener on a 1.25 cluster.

@friedrichwilken friedrichwilken self-assigned this Apr 25, 2023
@friedrichwilken
Copy link
Contributor

I used this tutorial to validate that the CEL-validation is working: CEL-tutorial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment