generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add defaulting to nats-cr in nats-manger #61
Merged
kyma-bot
merged 39 commits into
kyma-project:main
from
friedrichwilken:minor-refactoring
Jun 15, 2023
Merged
add defaulting to nats-cr in nats-manger #61
kyma-bot
merged 39 commits into
kyma-project:main
from
friedrichwilken:minor-refactoring
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
/test pull-nats-manager-unit-test |
c6abf53
to
7eb2ed4
Compare
mfaizanse
reviewed
Jun 14, 2023
Co-authored-by: Muhammad Faizan <mfaizanse@users.noreply.github.com>
mfaizanse
reviewed
Jun 15, 2023
internal/controller/nats/integrationtests/validation/integration_test.go
Show resolved
Hide resolved
mfaizanse
reviewed
Jun 15, 2023
(https://pkg.go.dev/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured#Unstructured) to the API-Server. If | ||
non-nil-able properties like ResourceRequirements (https://pkg.go.dev/k8s.io/api/core/v1#ResourceRequirements) are | ||
undefined they will be interpreted as "" and result in 0 instead of being replaced by the default value. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up for adding the comments!!!
mfaizanse
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
adds defaulting to the nats cr:
Related issue(s)