Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add defaulting to nats-cr in nats-manger #61

Merged
merged 39 commits into from
Jun 15, 2023
Merged

add defaulting to nats-cr in nats-manger #61

merged 39 commits into from
Jun 15, 2023

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Jun 2, 2023 •
edited

Description

Changes proposed in this pull request:

adds defaulting to the nats cr:

spec:
  cluster:
    size: 3
  jetStream:
    fileStorage:
      size: 1Gi
      storageClassName: default
    memStorage:
      enabled: false
      size: 20Mi
  logging:
    debug: false
    trace: false
  resources:
    limits:
      cpu: 20m
      memory: 64Mi
    requests:
      cpu: 5m
      memory: 16Mi

Related issue(s)

@friedrichwilken friedrichwilken requested a review from a team as a code owner June 2, 2023 21:07
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2023
@friedrichwilken friedrichwilken changed the title Minor refactoring refactoring in nats-manager Jun 2, 2023
@friedrichwilken friedrichwilken self-assigned this Jun 3, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2023
@friedrichwilken friedrichwilken changed the title refactoring in nats-manager add defaulting to nats-cr in nats-manger Jun 4, 2023
@friedrichwilken friedrichwilken linked an issue Jun 4, 2023 that may be closed by this pull request
Initial CRD handling #9
Closed
9 tasks
@friedrichwilken
Copy link
Contributor Author

/test pull-nats-manager-unit-test

@friedrichwilken friedrichwilken assigned muralov and mfaizanse and unassigned muralov Jun 15, 2023
mfaizanse
mfaizanse reviewed Jun 15, 2023
View reviewed changes
api/v1alpha1/nats_types.go
(https://pkg.go.dev/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured#Unstructured) to the API-Server. If
non-nil-able properties like ResourceRequirements (https://pkg.go.dev/k8s.io/api/core/v1#ResourceRequirements) are
undefined they will be interpreted as "" and result in 0 instead of being replaced by the default value.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up for adding the comments!!!

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 15, 2023
@kyma-bot kyma-bot merged commit 26450f4 into kyma-project:main Jun 15, 2023
1 check passed
@friedrichwilken friedrichwilken deleted the minor-refactoring branch June 15, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

@muralov muralov Awaiting requested review from muralov muralov is a code owner automatically assigned from kyma-project/eventing

Assignees

@mfaizanse mfaizanse

@friedrichwilken friedrichwilken

Labels
lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial CRD handling
4 participants
@friedrichwilken @mfaizanse @muralov @kyma-bot