add validation of memStorage and fileStorage
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/L
friedrichwilken
force-pushed
the
validate-fileStorage-and-memStorage-in-cr
branch
from
0c865ec
to
93d0a31
Compare
friedrichwilken
changed the title
Closed
9 tasks
fix typos and cleanup rewrite test names
friedrichwilken
force-pushed
the
validate-fileStorage-and-memStorage-in-cr
branch
from
5256d82
to
d6ff516
Compare
friedrichwilken
changed the title
memStoragememStorage and fileStorage
mfaizanse
previously approved these changes
Jun 16, 2023
…ing" This reverts commit da0195f.
mfaizanse
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
add validation of
spec.jetStream.memStorage: memStorage can only be enabled if size is not 0.add validation of
spec.jetStream.fileStorage: fileStorage cannot be edited once it was setalso, refactored some of the existing tests.
Related issue(s)