Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed envtest setup to run multiple instances and added a validation sample test #55

Merged
merged 5 commits into from
May 31, 2023
Merged

Fixed envtest setup to run multiple instances and added a validation sample test #55

merged 5 commits into from
May 31, 2023

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented May 30, 2023 •
edited by mfaizanse

Description

Changes proposed in this pull request:

  • Fixed envtest setup to run multiple instances and added a validation sample test.

Related issue(s)

@friedrichwilken friedrichwilken requested a review from a team as a code owner May 30, 2023 08:48
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2023
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2023
@friedrichwilken friedrichwilken changed the title rename enable to enabled validation May 30, 2023
@friedrichwilken
Copy link
Contributor Author

/test pull-nats-manager-unit-test

1 similar comment
@friedrichwilken
Copy link
Contributor Author

/test pull-nats-manager-unit-test

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2023
@friedrichwilken friedrichwilken changed the title validation [wip] test validation May 30, 2023
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2023
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2023
@mfaizanse mfaizanse changed the title [wip] test validation Fixed envtest setup to run multiple instances and added a validation sample test May 31, 2023
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2023
@mfaizanse mfaizanse linked an issue May 31, 2023 that may be closed by this pull request
Initial CRD handling #9
Closed
9 tasks
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2023
@mfaizanse
Copy link
Member

/test pull-nats-manager-unit-test

@kyma-bot kyma-bot added the lgtm Looks good to me! label May 31, 2023
@kyma-bot kyma-bot merged commit cc45225 into kyma-project:main May 31, 2023
1 check passed
@friedrichwilken friedrichwilken deleted the nats-cr-validation branch May 31, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

@marcobebway marcobebway Awaiting requested review from marcobebway marcobebway is a code owner automatically assigned from kyma-project/eventing

Assignees

@mfaizanse mfaizanse

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial CRD handling
3 participants
@friedrichwilken @mfaizanse @kyma-bot