Sync fixes #456
Merged
Sync fixes #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithvikvibhu
force-pushed
the
sync-fixes
branch
from
fb332f2
to
63b780b
Compare
Merged
|
Been working for days and no issues, syncs properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #448, fixes #455, fixes #429
lastKnownChainHeightwas never being set inWalletservice. And wallet sync never stopped because the node's height wasn't available (was always 0).Without lastKnownChainHeight, the namestate of each name used in Your Bids page was being retrieved as of height 0, not current height.
Now, both are updated in Wallet service on events from wallet and node.