-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes #458
Merged
Merged
Misc fixes #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithvikvibhu
added
bug
Something isn't working
dependent
Depends on another issue or PR to be resolved first
labels
Feb 1, 2022
I think this covers all small-change issues. For anyone who wants to review:
|
Math.max takes elements as arguments, not 1 arg of elements array
React complains in red `<div> cannot appear as a descendant of <p>.`
Only allow Net&Conn and custom RPC pages
overflow was added for kyokan#119 in Auctions page Bids, but also affected Records in Domain Manager
rithvikvibhu
force-pushed
the
misc-fixes
branch
from
February 6, 2022 07:14
6f748e6
to
c241c5d
Compare
Rebased and tested everything again on mainnet. |
rithvikvibhu
removed
the
dependent
Depends on another issue or PR to be resolved first
label
Feb 6, 2022
This was referenced May 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of small fixes that don't really need individual PRs. Each commit is independent and only a few lines long.
There are a few more I'd like to add, opening this draft PR so the issues are linked on GitHub and it shows the icon in issues list.
This must be merged after #456 as that's where the base is branched off from.
auction: fix NaN HNS lockup value
(closes #396)
Max lockup from all bid values were not calculated properly and panel had NaN HNS lockup (pic in issue).
auction: replace p with div tag
React throws a large error when there's a div inside a p, so changed the p to a div.
auction: show open as pending only until it is
(closes #394)
All 6 hours of open period used to say "please wait while OPEN is mined". Now pending OPEN, and waiting for bidding start have different messages / button text.
domain-manager: hide names in reveal
(closes #378)
Names were listed in Domain Manager even if the reveal period hadn't ended and the wallet was currently the owner with the highest revealed bid. Now, those are hidden.
txs: update tx history on new blocks
(closes #205)
Transaction history automatically updates on new blocks. The "key" for react's loop over transactions needed to include the pending status, otherwise the transaction component wouldn't update and stays as pending.
There's also a debounce (of 5 secs) when refreshing transactions because it's a bit heavy and rescans / syncing a lot of blocks would parse all transactions each time.
watchlist: get list on node start
(closes #457)
regression: Watchlist wasn't loaded on start. Now it does on node start (as watchlists are network-specific).
i18n: extract more hard-coded strings
(closes #454)
Added more strings to locales json. More info in issue ^.
Note: These strings have been updated in english and will need to be translated again when #446 is merged:
openSuccessText
,getCoinAirdrop1
text: fix airdrop amount, libusb ver
(closes #425, closes #445)
onboarding: disallow primary as wallet name
(closes #410)
primary
is excluded from the wallet list that's used to check if a wallet with the same name exists when creating a new one. So handled it specifically.This is related to (but does not close) #438 which seems like a better solution. Removing
primary
from all files will need a bigger commit in a separate PR.ui: add settings icon on login page
(related to #182)
If an RPC connection is broken without any wallets, there's no way to get back to a working state:
To break this deadlock, allow opening Settings directly from the login page. Only Network & Connection section's direct actions (start/stop node, spv, dns) and custom RPC modal are allowed. Trying anything else goes back to login.
ui: do not set state if unmounted
In
Account
:setState
was called after an await, that errored if the component was unmounted before the promise resolved. Now, it verifies that the component is still mounted before updating state.throttle updateHNSPrice
The CoinGecko API was being called way more than needed (state updates in Portfolio, etc.)
Now it is throttled to 2 mins.
ui: no overflow for records
To fix #119, overflow was added to collapsibles, but it also affected Records in Domain Manager, where content should not overflow:
This is fixed.