Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to docsy 0.7.0 #893

Closed
wants to merge 1 commit into from
Closed

Upgrade to docsy 0.7.0 #893

wants to merge 1 commit into from

Conversation

deining
Copy link
Contributor

@deining deining commented Jun 8, 2023

This upgrades the site to docsy 0.7.0.
Please note that this is a hack only. The key problem here is that the Kyverno project defines its one assets/scss/main.css. This is not considered best practice and was causing trouble when during upgrade. I solved it by adding a missing import to main.css which resolved the issue. As mentioned above, this is a hack only. I leave it up to the authors to move the custom content form main.css into _styles_project.scss and _variables_project.scss respectively and remove main.css afterwards.

  • I have read the contributing guidelines.
  • I have inspected the website preview for accuracy.
  • I have signed off my issue.

@welcome
Copy link

welcome bot commented Jun 8, 2023

Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off.

Signed-off-by: Andreas Deininger <andreas@deininger.net>
@chipzoller
Copy link
Contributor

Thank you very much for this, @deining! Appreciate you for trying to help us out. Unfortunately, I guess due to those custom changes, the site preview looks to have some CSS issues. Obviously not asking you to help us fix those, but we may have to pause on this PR until we can get a contractor to help us out.

@chalin
Copy link

chalin commented Jun 9, 2023

@chipzoller - if you open a CNCF servicedesk ticket, we can see if the techdocs team might be able to allocate resources to help out. /cc @nate-double-u

@chipzoller
Copy link
Contributor

Thanks for the offer but I haven't had a good experience with using the CNCF help desk for website assistance. I think we'll have to seek outside expertise.

@chalin
Copy link

chalin commented Jun 10, 2023

@chipzoller - wishing you better servicedesk experiences in the future, and a smooth migration for your project -- FYI, the following blog post might help: Migrating to Bootstrap 5.2.

@onweru onweru mentioned this pull request Jun 15, 2023
2 tasks
chipzoller added a commit that referenced this pull request Aug 2, 2023
* Upgrade to docsy 0.7.0
Signed-off-by: Andreas Deininger <andreas@deininger.net>

* use docsy's dedicated styles' override files

Signed-off-by: weru <fromweru@gmail.com>

* justify menu links right

Signed-off-by: weru <fromweru@gmail.com>

* parse lead shortcode as md

Signed-off-by: weru <fromweru@gmail.com>

* add smooth scroll & restrict overscroll

Signed-off-by: weru <fromweru@gmail.com>

* combine custom css files

Signed-off-by: weru <fromweru@gmail.com>

* bump min Hugo v0.75.0 > v0.109.0

Signed-off-by: weru <fromweru@gmail.com>

* pre-install postcss

Signed-off-by: weru <fromweru@gmail.com>

* fix logo aspect ratio

Signed-off-by: weru <fromweru@gmail.com>

* restore mobile nav collapse function

Signed-off-by: weru <fromweru@gmail.com>

* fix footer overflow

Signed-off-by: weru <fromweru@gmail.com>

* use hugo v0.114.0 on netlify

Signed-off-by: weru <fromweru@gmail.com>

* restore button styling

Signed-off-by: weru <fromweru@gmail.com>

* update go & node versions

Signed-off-by: weru <fromweru@gmail.com>

* update go-node versions all environments

Signed-off-by: weru <fromweru@gmail.com>

* update to docsy 0.7.1

Signed-off-by: weru <fromweru@gmail.com>

* exclude mermaid syntax snippets

Signed-off-by: weru <fromweru@gmail.com>

* restore snippets styling

Signed-off-by: weru <fromweru@gmail.com>

* update code snippets color

Signed-off-by: weru <fromweru@gmail.com>

---------

Signed-off-by: weru <fromweru@gmail.com>
Co-authored-by: Andreas Deininger <andreas@deininger.net>
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
@chipzoller
Copy link
Contributor

Thanks very much once again here, @deining. We got this addressed in #904 thanks to @onweru.

@chipzoller chipzoller closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants