-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch regression after #893 #904
Conversation
Signed-off-by: Andreas Deininger <andreas@deininger.net>
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
This PR looks good to me!
Glad to see your site at docsy v0.7.0 now! |
Signed-off-by: weru <fromweru@gmail.com>
Thanks, yes I see in the logs it's using Go 1.14. But that's not defined anywhere in the site nor is it in Netlify. Where is that coming from? In order to use Node 18 I had to set an environment variable in Netlify since we couldn't figure that out either. Any ideas or advice, @deining? |
https://docs.netlify.com/configure-builds/manage-dependencies/#go You can set
|
Thanks, good suggestion. @onweru could you incorporate those changes here? |
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
@deining, I'm seeing that if I remove the env var from the Netlify side and add it here in |
Signed-off-by: weru <fromweru@gmail.com>
Looks like the latest change did the trick!
|
Sorry for the delay here, @onweru. I noticed that a patch to 0.7 was released. Would you mind bumping up to that so we get the fixes, please? |
Signed-off-by: weru <fromweru@gmail.com>
@chipzoller, would you like me to restore the old format? |
Not necessarily, but what was the source or reason for the different styling? Is it something that could break in the future with Docsy upgrades potentially? |
I do see a problem with how Mermaid diagrams are being rendered in these changes, however, and this would need to be addressed. Newhttps://deploy-preview-904--kyverno.netlify.app/docs/installation/customization/#resource-filters ![]() Oldhttps://kyverno.io/docs/installation/customization/#resource-filters ![]() |
The Docsy upgrade introduced styling changes. Future Docsy upgrades could contain more styling changes. We would have to evaluate if we like those changes or not. |
I will fix the regressions. |
Signed-off-by: weru <fromweru@gmail.com>
Signed-off-by: weru <fromweru@gmail.com>
This is somewhat of a more minor concern, but I am seeing code blocks with quite a bit more padding around the actual text. See https://deploy-preview-904--kyverno.netlify.app/docs/installation/uninstallation/#uninstall-kyverno-with-yaml New ![]() Old ![]() |
In https://deploy-preview-904--kyverno.netlify.app/docs/writing-policies/match-exclude/#match-statements have you noticed that the newer inline code styling doesn't seem to be applied to code inside tip boxes? New ![]() Old ![]() |
This is looking good so far 👍 |
Just a couple things and I think we're good, @onweru. |
Signed-off-by: weru <fromweru@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
Related issue
#893
Proposed Changes
This PR
The changes here were applied on top of #893
Checklist