Patch regression after #893

[onweru]

Related issue

#893

Proposed Changes

This PR

1. Applies this recommendation
2. Fixes menu link alignment regression after Upgrade to docsy 0.7.0 #893
3. Re-applies smooth scroll
4. Fixes a markdown bug in the footer section

The changes here were applied on top of #893

Checklist

• I have read the contributing guidelines.
• I have inspected the website preview for accuracy.
• [] I have signed off my issue.

[chipzoller]

@deining would you kindly confirm that this PR incorporates the changes you recommended in your PR #893 to make the site more compatible with Docsy recommendations and future upgrades? Thanks very much.

[deining]

@deining would you kindly confirm that this PR incorporates the changes you recommended in your PR #893

This PR looks good to me!
I do have two minor recommendations though:

• hugo v0.114.0 was released just yesterday, so you can use this version for your deployment.
• currently you are installing/using Go version 1.14.4 with your netlify deploy, I would recommend to go for latest released version 1.20.5.

Glad to see your site at docsy v0.7.0 now!

[chipzoller]

Thanks, yes I see in the logs it's using Go 1.14. But that's not defined anywhere in the site nor is it in Netlify. Where is that coming from? In order to use Node 18 I had to set an environment variable in Netlify since we couldn't figure that out either. Any ideas or advice, @deining?

[deining]

Thanks, yes I see in the logs it's using Go 1.14. But that's not defined anywhere in the site nor is it in Netlify. Where is that coming from? In order to use Node 18 I had to set an environment variable in Netlify since we couldn't figure that out either. Any ideas or advice, @deining?

https://docs.netlify.com/configure-builds/manage-dependencies/#go

You can set GO_VERSION as environment variable, too. Or, what you also can do:
In netlify.tomladd these lines:

GO_VERSION = 1.20.5
NODE_VERSION = 18.16.0

[chipzoller]

Thanks, good suggestion. @onweru could you incorporate those changes here?

[chipzoller]

@deining, I'm seeing that if I remove the env var from the Netlify side and add it here in netlify.toml that the deployment preview is once again failing. It's also not picking up the Go version even though it is specified. Any idea why that is?

[chipzoller]

Looks like the latest change did the trick!

3:39:09 PM: Installing Go version 1.20.5 (requested 1.20.5)
3:39:13 PM: go version go1.20.5 linux/amd64
3:39:13 PM: Using PHP version 8.0
3:39:13 PM: Installing Hugo 0.114.0
3:39:13 PM: hugo v0.114.0-9df2ec7988e5a217a14901cc76c0b7e76b2e9f02+extended linux/amd64 BuildDate=2023-06-19T17:01:43Z VendorInfo=gohugoio
3:39:14 PM: Started restoring cached Node.js version
3:39:15 PM: Finished restoring cached Node.js version
3:39:15 PM: v18.16.0 is already installed.
3:39:15 PM: Now using node v18.16.0 (npm v9.5.1)

[chipzoller]

Sorry for the delay here, @onweru. I noticed that a patch to 0.7 was released. Would you mind bumping up to that so we get the fixes, please?

[chipzoller]

Not that it's necessarily a bad thing, but did you notice that code blocks now are slightly different?

New

Old

In-line code formatting is also slightly different.

New

Old

[onweru]

@chipzoller, would you like me to restore the old format?

[chipzoller]

Not necessarily, but what was the source or reason for the different styling? Is it something that could break in the future with Docsy upgrades potentially?

[chipzoller]

I do see a problem with how Mermaid diagrams are being rendered in these changes, however, and this would need to be addressed.

New

https://deploy-preview-904--kyverno.netlify.app/docs/installation/customization/#resource-filters

Old

https://kyverno.io/docs/installation/customization/#resource-filters

[onweru]

Not necessarily, but what was the source or reason for the different styling? Is it something that could break in the future with Docsy upgrades potentially?

The Docsy upgrade introduced styling changes. Future Docsy upgrades could contain more styling changes. We would have to evaluate if we like those changes or not.

[onweru]

I will fix the regressions.

[chipzoller]

This is somewhat of a more minor concern, but I am seeing code blocks with quite a bit more padding around the actual text. See https://deploy-preview-904--kyverno.netlify.app/docs/installation/uninstallation/#uninstall-kyverno-with-yaml

New

Old

[chipzoller]

In https://deploy-preview-904--kyverno.netlify.app/docs/writing-policies/match-exclude/#match-statements have you noticed that the newer inline code styling doesn't seem to be applied to code inside tip boxes?

New

Old

[chipzoller]

This is looking good so far 👍

[chipzoller]

Just a couple things and I think we're good, @onweru.

[chipzoller]

Thanks so much!