-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support AWS ECR Private Container Registry based on PostgreSQL
#2624
Merged
kyujin-cho
merged 3 commits into
main
from
topic/08-03-feat_support_aws_ecr_private_container_registry_based_on_postgresql_
Sep 30, 2024
Merged
feat: Support AWS ECR Private Container Registry based on PostgreSQL
#2624
kyujin-cho
merged 3 commits into
main
from
topic/08-03-feat_support_aws_ecr_private_container_registry_based_on_postgresql_
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2024
2 tasks
08d6763
to
1dc6851
Compare
e1ed86b
to
d077f8a
Compare
17bafa0
to
4f65884
Compare
d077f8a
to
c51e229
Compare
4f65884
to
db9c829
Compare
c51e229
to
0364b8b
Compare
db9c829
to
c8494b0
Compare
0364b8b
to
3032175
Compare
c8494b0
to
02c5a90
Compare
3032175
to
a7bbc69
Compare
02c5a90
to
e0ae7c0
Compare
a7bbc69
to
b760be8
Compare
e0ae7c0
to
c7c0945
Compare
b760be8
to
ac34a6d
Compare
51152a2
to
3ebcdef
Compare
bc35ab6
to
59f390b
Compare
3ebcdef
to
4cc2b2e
Compare
59f390b
to
e72edef
Compare
4cc2b2e
to
0d8ad9a
Compare
e72edef
to
e91213b
Compare
0d8ad9a
to
d8fecb0
Compare
e91213b
to
4b65e36
Compare
d8fecb0
to
a3ddc76
Compare
4b65e36
to
f05d2c7
Compare
a3ddc76
to
c1aac4a
Compare
f05d2c7
to
5444b1b
Compare
c1aac4a
to
d66a76b
Compare
5444b1b
to
f213a88
Compare
d66a76b
to
ac2e47c
Compare
f213a88
to
34b09df
Compare
ac2e47c
to
8556cdd
Compare
34b09df
to
de4858e
Compare
8556cdd
to
730184d
Compare
Base automatically changed from
topic/08-03-feat_support_aws_ecr_public_container_registry_based_on_postgresql_
to
main
September 30, 2024 15:40
de4858e
to
0d9807a
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #2337.
Test
ecr
Manually tested it using the following methods.
In this PR, the
cr.backend.ai/stable/python:3.9-ubuntu20.04
image is used as a placeholder for testing.Prerequisite
Create and configure the relevant users and policies appropriately through AWS IAM for testing this PR.
Then, generate the "access key" and store the
access_key
andsecret_access_key
in etcd.cr.backend.ai/stable/python
image to your AWS ECR package for testing.fixtures/manager/example-container-registries-aws-ecr.json
file, execute the following command.container_registry
column of thegroups
table.Note
Empty project values are not allowed.
<aws_account_id>.dkr.ecr.<region>.amazonaws.com
value toallowed_docker_registries
column ofdomains
table using below commandTest scenarios
Verify that the container registry added in this PR is functioning based on several scenarios.
If there are additional scenarios that need testing, please leave a comment.
1. Image Rescan
Image rescanning should work through the following command.
2. Create a session from the pulled image
Run a session using the downloaded image.
3. Commit the changes and push it to the container registry.
Commit the changes using the
convert-to-image
command and push them to the container registry.Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--2624.org.readthedocs.build/en/2624/
📚 Documentation preview 📚: https://sorna-ko--2624.org.readthedocs.build/ko/2624/