-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace image rescan command's --local
flag with the local
type ContainerRegistry record
#2665
Merged
kyujin-cho
merged 5 commits into
main
from
topic/08-07-feat_replace_rescan_command_s_--local_flag_with_local_container_registry_record
Sep 30, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2024
2 tasks
2 tasks
--local
flag with Local container registry record--local
flag with the local container registry record
3 tasks
--local
flag with the local container registry record--local
flag with the local
type container registry record
30576a2
to
31e78a2
Compare
2989bf6
to
e1ce676
Compare
31e78a2
to
aecba67
Compare
e1ce676
to
da7e43b
Compare
aecba67
to
b5ed78b
Compare
da7e43b
to
9f13201
Compare
b5ed78b
to
f01835b
Compare
dbfb22a
to
0ffc1c6
Compare
f01835b
to
c3eba55
Compare
0ffc1c6
to
37488ec
Compare
59f390b
to
e72edef
Compare
f386298
to
a2a9213
Compare
e72edef
to
e91213b
Compare
a2a9213
to
a45cdb8
Compare
e91213b
to
4b65e36
Compare
a45cdb8
to
21477bd
Compare
4b65e36
to
f05d2c7
Compare
21477bd
to
d2ec79e
Compare
f05d2c7
to
5444b1b
Compare
d2ec79e
to
5620f3b
Compare
5444b1b
to
f213a88
Compare
5620f3b
to
2fee789
Compare
f213a88
to
34b09df
Compare
2fee789
to
fa6f23a
Compare
--local
flag with the local
type ContainerRegistry record--local
flag with the local
type ContainerRegistry record
34b09df
to
de4858e
Compare
fa6f23a
to
379316c
Compare
de4858e
to
0d9807a
Compare
Base automatically changed from
topic/08-03-feat_support_aws_ecr_private_container_registry_based_on_postgresql_
to
main
September 30, 2024 15:51
379316c
to
ab67717
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:agent
Related to Agent component
comp:cli
Related to CLI component
comp:manager
Related to Manager component
size:L
100~500 LoC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #411, ref: #1097
This PR removes the existing image rescan code that uses the
--local
flag and instead uses aLocal
type container registry record to reuse existing code paths.Test
Manually tested according to the following procedure.
Dockerfile
with the following content.(Copy-pasted from feat: Support scanning the local Docker daemon's image list #1097 (comment))
docker build
Perform an image rescan.
Verify that the built
bai-python
image has been scanned correctly.Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--2665.org.readthedocs.build/en/2665/
📚 Documentation preview 📚: https://sorna-ko--2665.org.readthedocs.build/ko/2665/