-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Make project
column nullable and improve container registry migration script
#2978
Merged
jopemachine
merged 12 commits into
main
from
topic/10-25-refactor_make_project_column_nullable_and_improve_migration_script
Nov 6, 2024
Merged
refactor: Make project
column nullable and improve container registry migration script
#2978
jopemachine
merged 12 commits into
main
from
topic/10-25-refactor_make_project_column_nullable_and_improve_migration_script
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
Related to Manager component
comp:common
Related to Common component
require:db-migration
Automatically set when alembic migrations are added or updated
size:L
100~500 LoC
labels
Oct 25, 2024
This was referenced Oct 25, 2024
jopemachine
force-pushed
the
topic/10-25-refactor_make_project_column_nullable_and_improve_migration_script
branch
3 times, most recently
from
October 25, 2024 06:59
13fea68
to
6a2fc14
Compare
jopemachine
changed the title
refactor: Make project column nullable and improve migration script
refactor: Make Oct 25, 2024
project
column nullable and improve container registry migration script
jopemachine
force-pushed
the
topic/10-25-refactor_make_project_column_nullable_and_improve_migration_script
branch
3 times, most recently
from
October 29, 2024 05:12
41dd818
to
24b8f9a
Compare
kyujin-cho
force-pushed
the
topic/10-25-refactor_make_project_column_nullable_and_improve_migration_script
branch
from
October 31, 2024 09:49
4820271
to
7f04f87
Compare
jopemachine
deleted the
topic/10-25-refactor_make_project_column_nullable_and_improve_migration_script
branch
November 6, 2024 09:35
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 6, 2024
…ry migration script (#2978) Co-authored-by: Sanghun Lee <sanghun@lablup.com> Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 2978
This was referenced Nov 21, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:common
Related to Common component
comp:manager
Related to Manager component
require:db-migration
Automatically set when alembic migrations are added or updated
size:L
100~500 LoC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1917.
project
column nullableproject
column nullableupgrade()
to automatically generate the corresponding container registry row instead of raising an error when no container registry exists for the image canonical name.Thoughts about
local
type container registry recordLocal-type container registry records currently do not contain meaningful information. Additionally, having more than one local container registry type would be awkward.
Whether an image is local can be determined by checking if the container registry pointed to by
image.registry_id
is of the Local type, making theis_local
column redundant.Container registry row auto-generation example
Caution
This PR contains updates to a revision script which has already been published to the stable release. Existing clusters operating Backend.AI 24.09 should execute following script to manually elaborate the database schema:
Checklist: (if applicable)