Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BA-470): Improve local type container registry handling #2980

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Oct 25, 2024

Resolves #3403 (BA-470).

Currently, even local type container registries are constrained by the project value and the name of a non-existent virtual container registry.

This PR removes all unnecessary restrictions, allowing local images to be scanned as they are.

Example

13

Note

Setting the project column to None allows the scanned image name to become the canonical image name, making the process more natural.

For example, in the previous code, we had to use commands like backend.ai session create local/stable/python, but now we can simplify it to backend.ai session create python.

Important

Please note that this PR changes the way image canonical of Local type images are handled.


Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

📚 Documentation preview 📚: https://sorna--2980.org.readthedocs.build/en/2980/


📚 Documentation preview 📚: https://sorna-ko--2980.org.readthedocs.build/ko/2980/

Copy link
Member Author

jopemachine commented Oct 25, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch from bdbffad to 4dc04ff Compare October 25, 2024 06:47
@jopemachine jopemachine force-pushed the topic/10-25-refactor_image_rescanning_to_be_project-aware branch from 3924686 to 7b52ea4 Compare October 25, 2024 06:47
@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch 2 times, most recently from 9248457 to 91358b5 Compare October 25, 2024 06:51
@jopemachine jopemachine force-pushed the topic/10-25-refactor_image_rescanning_to_be_project-aware branch from d98e2e2 to 5bcf0f6 Compare October 25, 2024 06:54
@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch from 91358b5 to 6f76f37 Compare October 25, 2024 06:55
@jopemachine jopemachine force-pushed the topic/10-25-refactor_image_rescanning_to_be_project-aware branch from 5bcf0f6 to a04bf53 Compare October 25, 2024 06:59
@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch from 6f76f37 to 0111045 Compare October 25, 2024 06:59
@jopemachine jopemachine force-pushed the topic/10-25-refactor_image_rescanning_to_be_project-aware branch from a04bf53 to d468c65 Compare October 25, 2024 07:09
@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch 2 times, most recently from 5ecd183 to 1307058 Compare October 25, 2024 07:20
@jopemachine jopemachine added this to the 24.09 milestone Oct 25, 2024
@jopemachine jopemachine marked this pull request as ready for review October 25, 2024 11:58
@jopemachine jopemachine marked this pull request as draft October 25, 2024 12:57
@jopemachine jopemachine force-pushed the topic/10-25-refactor_image_rescanning_to_be_project-aware branch from 67de168 to 15eb897 Compare October 28, 2024 13:21
@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch from f81b2c5 to b9c2f50 Compare October 28, 2024 13:21
@jopemachine jopemachine force-pushed the topic/10-25-refactor_image_rescanning_to_be_project-aware branch from 15eb897 to d4c47cb Compare October 28, 2024 13:26
@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch 2 times, most recently from 135bc87 to b9e3e99 Compare October 28, 2024 13:29
@jopemachine jopemachine force-pushed the topic/10-25-refactor_image_rescanning_to_be_project-aware branch from 26fb0d3 to d86b85e Compare October 29, 2024 05:12
@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch from b9e3e99 to ca114f1 Compare October 29, 2024 05:12
@kyujin-cho kyujin-cho force-pushed the topic/10-25-refactor_image_rescanning_to_be_project-aware branch from d86b85e to df37043 Compare October 31, 2024 09:49
@kyujin-cho kyujin-cho force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch from ca114f1 to 8ec4a64 Compare October 31, 2024 09:50
@jopemachine jopemachine force-pushed the topic/12-10-feat_enable_rescanimage_by_project branch from b7c3e3e to 48f65da Compare January 14, 2025 07:47
@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch from 5128a23 to d2e0127 Compare January 14, 2025 07:47
@jopemachine jopemachine force-pushed the topic/10-25-feat_improve_local_type_container_registry_handling branch from 44c80e7 to bb05c56 Compare January 14, 2025 07:51
Co-authored-by: octodog <mu001@lablup.com>
Base automatically changed from topic/12-10-feat_enable_rescanimage_by_project to main January 16, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:agent Related to Agent component comp:common Related to Common component comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants