-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BA-470): Improve local type container registry handling #2980
Draft
jopemachine
wants to merge
65
commits into
main
Choose a base branch
from
topic/10-25-feat_improve_local_type_container_registry_handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(BA-470): Improve local type container registry handling #2980
jopemachine
wants to merge
65
commits into
main
from
topic/10-25-feat_improve_local_type_container_registry_handling
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
Related to Manager component
comp:agent
Related to Agent component
size:S
10~30 LoC
labels
Oct 25, 2024
2 tasks
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
from
October 25, 2024 06:47
bdbffad
to
4dc04ff
Compare
jopemachine
force-pushed
the
topic/10-25-refactor_image_rescanning_to_be_project-aware
branch
from
October 25, 2024 06:47
3924686
to
7b52ea4
Compare
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
2 times, most recently
from
October 25, 2024 06:51
9248457
to
91358b5
Compare
jopemachine
force-pushed
the
topic/10-25-refactor_image_rescanning_to_be_project-aware
branch
from
October 25, 2024 06:54
d98e2e2
to
5bcf0f6
Compare
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
from
October 25, 2024 06:55
91358b5
to
6f76f37
Compare
jopemachine
force-pushed
the
topic/10-25-refactor_image_rescanning_to_be_project-aware
branch
from
October 25, 2024 06:59
5bcf0f6
to
a04bf53
Compare
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
from
October 25, 2024 06:59
6f76f37
to
0111045
Compare
jopemachine
force-pushed
the
topic/10-25-refactor_image_rescanning_to_be_project-aware
branch
from
October 25, 2024 07:09
a04bf53
to
d468c65
Compare
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
2 times, most recently
from
October 25, 2024 07:20
5ecd183
to
1307058
Compare
jopemachine
force-pushed
the
topic/10-25-refactor_image_rescanning_to_be_project-aware
branch
from
October 28, 2024 13:21
67de168
to
15eb897
Compare
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
from
October 28, 2024 13:21
f81b2c5
to
b9c2f50
Compare
jopemachine
force-pushed
the
topic/10-25-refactor_image_rescanning_to_be_project-aware
branch
from
October 28, 2024 13:26
15eb897
to
d4c47cb
Compare
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
2 times, most recently
from
October 28, 2024 13:29
135bc87
to
b9e3e99
Compare
jopemachine
force-pushed
the
topic/10-25-refactor_image_rescanning_to_be_project-aware
branch
from
October 29, 2024 05:12
26fb0d3
to
d86b85e
Compare
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
from
October 29, 2024 05:12
b9e3e99
to
ca114f1
Compare
kyujin-cho
force-pushed
the
topic/10-25-refactor_image_rescanning_to_be_project-aware
branch
from
October 31, 2024 09:49
d86b85e
to
df37043
Compare
kyujin-cho
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
from
October 31, 2024 09:50
ca114f1
to
8ec4a64
Compare
jopemachine
force-pushed
the
topic/12-10-feat_enable_rescanimage_by_project
branch
from
January 14, 2025 07:47
b7c3e3e
to
48f65da
Compare
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
from
January 14, 2025 07:47
5128a23
to
d2e0127
Compare
jopemachine
force-pushed
the
topic/10-25-feat_improve_local_type_container_registry_handling
branch
from
January 14, 2025 07:51
44c80e7
to
bb05c56
Compare
Co-authored-by: octodog <mu001@lablup.com>
Base automatically changed from
topic/12-10-feat_enable_rescanimage_by_project
to
main
January 16, 2025 09:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:agent
Related to Agent component
comp:common
Related to Common component
comp:manager
Related to Manager component
require:db-migration
Automatically set when alembic migrations are added or updated
size:L
100~500 LoC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3403 (BA-470).
Currently, even
local
type container registries are constrained by the project value and the name of a non-existent virtual container registry.This PR removes all unnecessary restrictions, allowing local images to be scanned as they are.
Example
Note
Setting the project column to
None
allows the scanned image name to become the canonical image name, making the process more natural.For example, in the previous code, we had to use commands like
backend.ai session create local/stable/python
, but now we can simplify it tobackend.ai session create python
.Important
Please note that this PR changes the way image canonical of Local type images are handled.
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--2980.org.readthedocs.build/en/2980/
📚 Documentation preview 📚: https://sorna-ko--2980.org.readthedocs.build/ko/2980/