fix: Swap the ports that client and manager are looking at #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaminyam
added
comp:installer
Comment on lines
841
to
+845
| storage_proxy_client_facing_addr=ServerAddr( | ||
| bind=HostPortPair(public_component_bind_address, 6022), | ||
| face=HostPortPair(public_facing_address, 6022), | ||
| bind=HostPortPair(public_component_bind_address, 6021), | ||
| face=HostPortPair(public_facing_address, 6021), | ||
| ), | ||
| storage_proxy_manager_facing_addr=ServerAddr(HostPortPair("127.0.0.1", 6022)), |
There was a problem hiding this comment.
Can you please check if the code currently using ports 6021 and 6022 in backend.ai is okay? @Yaminyam
There was a problem hiding this comment.
This part is irrelevant to the behavior because it is the part that generates the config file.
As mentioned in the issue, we change it to be consistent with the port we use by default.
HyeockJinKim
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3138
Checklist: (if applicable)