Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Swap the ports that client and manager are looking at #3139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Swap the ports that client and manager are looking at #3139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e73847b
fix: Swap the ports that client and manager are looking at
Yaminyam Nov 26, 2024
a063da0
Merge branch 'main' into chore/installer-storage-proxy-port
Yaminyam Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ai/backend/install/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,11 +838,11 @@ def hydrate_install_info(self) -> InstallInfo:
agent_watcher_addr=ServerAddr(HostPortPair("127.0.0.1", 6019)),
agent_ipc_base_path="ipc/agent",
agent_var_base_path="var/agent",
storage_proxy_manager_facing_addr=ServerAddr(HostPortPair("127.0.0.1", 6021)),
storage_proxy_client_facing_addr=ServerAddr(
bind=HostPortPair(public_component_bind_address, 6022),
face=HostPortPair(public_facing_address, 6022),
bind=HostPortPair(public_component_bind_address, 6021),
face=HostPortPair(public_facing_address, 6021),
),
storage_proxy_manager_facing_addr=ServerAddr(HostPortPair("127.0.0.1", 6022)),
Comment on lines 841 to +845
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check if the code currently using ports 6021 and 6022 in backend.ai is okay? @Yaminyam

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is irrelevant to the behavior because it is the part that generates the config file.
As mentioned in the issue, we change it to be consistent with the port we use by default.

storage_proxy_ipc_base_path="ipc/storage-proxy",
storage_proxy_var_base_path="var/storage-proxy",
storage_proxy_random=secrets.token_hex(32),
Expand Down