refactor(main): using new runtime interface #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sealos-ci-robot
added
area/apply
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3691 +/- ##
=======================================
Coverage 66.46% 66.46%
=======================================
Files 8 8
Lines 656 656
=======================================
Hits 436 436
Misses 173 173
Partials 47 47
☔ View full report in Codecov by Sentry. |
cuisongliu
force-pushed
the
runtime-interface
branch
from
bd2b914 to
4ad07ce
Compare
fengxsong
reviewed
Aug 21, 2023
fengxsong
reviewed
Aug 21, 2023
fengxsong
approved these changes
Aug 21, 2023
|
🤖 says: E2E Apply Test Result: Success 🎉🎉! |
cuisongliu
force-pushed
the
runtime-interface
branch
from
78e73d5 to
308e9f8
Compare
cuisongliu
added
need-e2e-apply-test
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu
force-pushed
the
runtime-interface
branch
from
66ec411 to
6bcf552
Compare
cuisongliu
added
need-e2e-apply-test
|
🤖 says: E2E ARM64 Apply Test Result: |
|
/cherry-pick release-v4.3 |
|
🤖 says: cherry pick action finished successfully 🎉! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Aug 22, 2023
* refactor(main): using new runtime interface Signed-off-by: cuisongliu <cuisongliu@qq.com> * feature(main): using up and down interface Signed-off-by: cuisongliu <cuisongliu@qq.com> * feature(main): using up and down interface Signed-off-by: cuisongliu <cuisongliu@qq.com> * feature(main): using up and down interface Signed-off-by: cuisongliu <cuisongliu@qq.com> --------- Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu
added a commit
that referenced
this pull request
Aug 22, 2023
* refactor(main): using new runtime interface * feature(main): using up and down interface * feature(main): using up and down interface * feature(main): using up and down interface --------- Signed-off-by: cuisongliu <cuisongliu@qq.com> Co-authored-by: cuisongliu <cuisongliu@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at bd2b914
Summary
🔧🚀🧪
Refactored the
pkg/apply/processorandpkg/runtimepackages to simplify and unify the interface and logic of cluster operations. Renamed and replaced some methods to make them more generic and consistent. Updated the test cases to reflect the changes.Walkthrough
GetKubeadmConfigwithGetConfiginpkg/apply/gen.go,pkg/apply/processor/install.go, andpkg/client-go/kubernetes/expansion_test.go(link, link, link, link)JoinNodes,DeleteNodes,JoinMasters, andDeleteMasterswithScaleNodesandScaleMastersinpkg/apply/processor/create.go,pkg/apply/processor/scale.go, andpkg/runtime/runtime.go(link, link, link, link, link)UpgradeClusterwithUpgradeinpkg/apply/processor/install.goandpkg/runtime/runtime.go(link, link)