Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Automated CherryPick Update for release-v4.3 #3732

Merged
merged 1 commit into from
Aug 22, 2023
Merged

docs: Automated CherryPick Update for release-v4.3 #3732

merged 1 commit into from
Aug 22, 2023

Conversation

sealos-ci-robot
Copy link
Member

@sealos-ci-robot sealos-ci-robot commented Aug 22, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 9dbed1a

Summary

🔧🚀🧹

Refactored the pkg/runtime package and updated the pkg/apply package and the pkg/client-go/kubernetes package to use the new and renamed methods from the pkg/runtime package. The refactoring aims to simplify and consolidate the logic for scaling and upgrading the cluster.

Sing, O Muse, of the valiant code reviewers who scrutinized
The mighty pull request of the skillful developer, who refactored
The runtime package and the apply processor, and simplified
The methods for scaling and upgrading the glorious cluster.

Walkthrough

  • Simplify the interface and naming of the runtime methods by renaming GetKubeadmConfig to GetConfig and UpgradeCluster to Upgrade (link, link, link, link, link)
  • Consolidate the logic for scaling the cluster into two methods: ScaleUp and ScaleDown, replacing the old JoinMasters, JoinNodes, DeleteMasters, and DeleteNodes methods (link, link, link, link, link)
  • Update the NewClusterFromGenArgs function in pkg/apply/gen.go to use the new GetConfig method (link)
  • Update the Join function in pkg/apply/processor/create.go to use the new ScaleUp method (link)
  • Update the UpgradeIfNeed function in pkg/apply/processor/install.go to use the new Upgrade method (link)
  • Update the Delete and Join functions in pkg/apply/processor/scale.go to use the new ScaleDown and ScaleUp methods (link, link)
  • Update the TestGetKubeadmConfig function in pkg/client-go/kubernetes/expansion_test.go to use the new GetConfig method (link)

Automated changes by create-pull-request GitHub action

@cuisongliu
refactor(main): using new runtime interface (#3691)
9dbed1a 
* refactor(main): using new runtime interface

Signed-off-by: cuisongliu <cuisongliu@qq.com>

* feature(main): using up and down interface

Signed-off-by: cuisongliu <cuisongliu@qq.com>

* feature(main): using up and down interface

Signed-off-by: cuisongliu <cuisongliu@qq.com>

* feature(main): using up and down interface

Signed-off-by: cuisongliu <cuisongliu@qq.com>

---------

Signed-off-by: cuisongliu <cuisongliu@qq.com>
@cuisongliu cuisongliu merged commit 8f63707 into release-v4.3 Aug 22, 2023
@cuisongliu cuisongliu deleted the cherry-pick-release-v4.3-3691 branch August 22, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

Assignees
No one assigned
Labels
area/apply sealos run/apply/scale/reset area/lifecycle-management area/runtime area/test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sealos-ci-robot @cuisongliu