Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore http server close error #3854

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

fengxsong
Copy link
Collaborator

@fengxsong fengxsong commented Sep 6, 2023

πŸ€– Generated by Copilot at 1700e0b

Summary

πŸ›πŸš§πŸ“

Fix a deadlock bug in syncViaHTTP and clarify the error handling logic. Improve the registry synchronization in pkg/filesystem/registry/sync.go.

syncViaHTTP fixed
error group waits for all
snow melts in channel

Walkthrough

  • Fix a bug where the error returned by syncViaHTTP was not the error from the error group (link)
  • Send the error from the error group to the channel in a separate goroutine to avoid deadlock (link)
  • Add a comment to explain the purpose of the channel write (link)

@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 932
βœ… Successful 392
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 539
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@fengxsong
Copy link
Collaborator Author

fix #3780

@sealos-ci-robot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. πŸ‘―πŸ‘­πŸ»πŸ§‘β€πŸ€β€πŸ§‘πŸ‘«πŸ§‘πŸΏβ€πŸ€β€πŸ§‘πŸ»πŸ‘©πŸΎβ€πŸ€β€πŸ‘¨πŸΏπŸ‘¬πŸΏ


fix #3780

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch has no changes to coverable lines.

πŸ“’ Thoughts on this report? Let us know!.

@cuisongliu cuisongliu linked an issue Sep 6, 2023 that may be closed by this pull request
@cuisongliu cuisongliu added this to the v4.4 milestone Sep 6, 2023
@cuisongliu cuisongliu merged commit b0f6c59 into labring:main Sep 6, 2023
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

πŸ€– says: cherry pick action finished successfully πŸŽ‰!
See: https://github.com/labring/sealos/actions/runs/6099366609

cuisongliu pushed a commit to cuisongliu/sealos that referenced this pull request Sep 29, 2023
cuisongliu added a commit that referenced this pull request Sep 29, 2023
* fix: dnsDomain does not take effect in kubelet (#3834) (#3835)

Signed-off-by: yangxg <yangxggo@163.com>
Co-authored-by: yangxg <yangxggo@163.com>
(cherry picked from commit c60b2fd)

* fix: ignore http server close error (#3854) (#3857)

(cherry picked from commit 2d4d78b)

* fix: skip same path (#3898) (#3899)

Co-authored-by: 榴莲榴莲 <78798447@qq.com>
(cherry picked from commit a256283)

* fix: disable scp checksum by default (#3913) (#3919)

Co-authored-by: fengxsong <fengxsong@outlook.com>
(cherry picked from commit 96cb79d)

* feat: support timeout setting for lvscare http prober (#3901) (#3905)

Co-authored-by: fengxsong <fengxsong@outlook.com>
(cherry picked from commit 6bd5c0a)

* feature: kubefile CMD support ENV variable format (#3921) (#3942)

Co-authored-by: Zihan Li <eden.zh.li@outlook.com>
(cherry picked from commit 4b5f3fe)

* delete cr build for buildah (#3953) (#3954)

Co-authored-by: yy <56745951+lingdie@users.noreply.github.com>
(cherry picked from commit 865803c)

* delete: controller part and useless service. (#3950)

* delete controllers and useless service.

* delete buildah image cr part.

* delete ci.

* roll back

(cherry picked from commit 076c7c7)
Signed-off-by: cuisongliu <cuisongliu@qq.com>

* fix: using extra valid status codes when response status code greater than 400 (#3986) (#3988)

Co-authored-by: fengxsong <fengxsong@outlook.com>
(cherry picked from commit 7be765f)

* feature(main): add lvscare gomod (#3995)

Signed-off-by: cuisongliu <cuisongliu@qq.com>
(cherry picked from commit 050d70b)

* fix(main): sync cert for cert cmd

Signed-off-by: cuisongliu <cuisongliu@qq.com>

#3708 #3887

---------

Co-authored-by: sealos-ci-robot <109538726+sealos-ci-robot@users.noreply.github.com>
Co-authored-by: yy <56745951+lingdie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: retry http server
3 participants