Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete: controller part and useless service. #3950

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Sep 18, 2023

🤖 Generated by Copilot at 477ec06

Summary

📱🛠️🌐

Removed the controllers/account directory and all its files, which contained the code and configuration for the account controller. This controller is no longer needed as the account logic has been moved to a separate service.

is_valid checks
refactored for clarity
autumn leaves falling

Walkthrough

  • Delete the entire controllers/account directory and all its contents (link-link)
  • Remove the code for managing account, billing, debt, payment, and price resources and their webhooks (link-link, link)
  • Remove the configuration files for certmanager and CRDs (link-link)
  • Remove the Dockerfile, Makefile, PROJECT, README, and gitignore files for the account controller (link-link)

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@lingdie lingdie added this to the v4.4 milestone Sep 18, 2023
@cuisongliu cuisongliu modified the milestones: v4.4, cherry-pick Sep 18, 2023
@lingdie lingdie modified the milestones: cherry-pick, v4.4 Sep 18, 2023
@cuisongliu cuisongliu merged commit 076c7c7 into labring:release-v4.4 Sep 18, 2023
29 checks passed
cuisongliu pushed a commit to cuisongliu/sealos that referenced this pull request Sep 29, 2023
* delete controllers and useless service.

* delete buildah image cr part.

* delete ci.

* roll back

(cherry picked from commit 076c7c7)
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu added a commit that referenced this pull request Sep 29, 2023
* fix: dnsDomain does not take effect in kubelet (#3834) (#3835)

Signed-off-by: yangxg <yangxggo@163.com>
Co-authored-by: yangxg <yangxggo@163.com>
(cherry picked from commit c60b2fd)

* fix: ignore http server close error (#3854) (#3857)

(cherry picked from commit 2d4d78b)

* fix: skip same path (#3898) (#3899)

Co-authored-by: 榴莲榴莲 <78798447@qq.com>
(cherry picked from commit a256283)

* fix: disable scp checksum by default (#3913) (#3919)

Co-authored-by: fengxsong <fengxsong@outlook.com>
(cherry picked from commit 96cb79d)

* feat: support timeout setting for lvscare http prober (#3901) (#3905)

Co-authored-by: fengxsong <fengxsong@outlook.com>
(cherry picked from commit 6bd5c0a)

* feature: kubefile CMD support ENV variable format (#3921) (#3942)

Co-authored-by: Zihan Li <eden.zh.li@outlook.com>
(cherry picked from commit 4b5f3fe)

* delete cr build for buildah (#3953) (#3954)

Co-authored-by: yy <56745951+lingdie@users.noreply.github.com>
(cherry picked from commit 865803c)

* delete: controller part and useless service. (#3950)

* delete controllers and useless service.

* delete buildah image cr part.

* delete ci.

* roll back

(cherry picked from commit 076c7c7)
Signed-off-by: cuisongliu <cuisongliu@qq.com>

* fix: using extra valid status codes when response status code greater than 400 (#3986) (#3988)

Co-authored-by: fengxsong <fengxsong@outlook.com>
(cherry picked from commit 7be765f)

* feature(main): add lvscare gomod (#3995)

Signed-off-by: cuisongliu <cuisongliu@qq.com>
(cherry picked from commit 050d70b)

* fix(main): sync cert for cert cmd

Signed-off-by: cuisongliu <cuisongliu@qq.com>

#3708 #3887

---------

Co-authored-by: sealos-ci-robot <109538726+sealos-ci-robot@users.noreply.github.com>
Co-authored-by: yy <56745951+lingdie@users.noreply.github.com>
@lingdie lingdie deleted the mv-release-v4.4 branch October 11, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants