Added CIFS Support and fixed comparison statement for minimum Count of hosts #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lae
requested changes
Jul 6, 2024
There was a problem hiding this comment.
Please rebase all of these commits into logical ones (i.e. no test/typo fix commits and no merge commits) and use descriptive commit messages for the initial line (one commit per feature/change, e.g. 081b98a is a good one even though it kind of runs a bit long). You can force push to this PR when done with the rebase.
|
Replaced by #251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and added support for namespaces in pbs, and ability to specify knet_priority for cororsync via pve_cluster_prio0 and 1 (In my case i wanted to be able to use second link for sperate cororsync traffic with own switch but wanted still the failover to my public network if switch goes down