Support for CIFS storages, namespacing in PBS, and ranking interfaces for corosync #251
Conversation
Add abbility to add cifs as storage to proxmox, see proxmox_storage.py for Usage Examples
added link priority for link0 and 1 to allow to define second link as main for corosync if the user has a seperate switch/network for cororsync
There was a problem hiding this comment.
Thanks for the history cleanup.
In addition to the comments, can you add documentation for the new role variables as well as the CIFS storage support (this should go under Storage Management) to the README?
Also, I'm not sure what value is supported to go into pve_cluster_prio0 etc (documentation should help here), but if I'm assuming correctly that it's an integer for ranking that particular interface, then I think pve_cluster_prio0 etc should really be pve_cluster_addr0_priority (and same for prio1), otherwise it gives me the impression that prio0 is yet another interface and not associated to addr0. These role variables should also still be shown in the defaults file, commented out (just like pve_cluster_addr1) if you don't want to actually give them a default, so that people looking at the defaults file know they exist.
see PR#251
Update README.md Added Information to Cororsync Priority
edv-pi
force-pushed
the
develop
branch
3 times, most recently
from
cdf8a81
to
8c3b1ed
Compare
removed duplicate of namespace declaration Added comments for better visibility
lae
changed the title
There was a problem hiding this comment.
Weird that the PVE docs doesn't mention namespaces (it's a valid flag, just seems undocumented).
https://github.com/proxmox/pve-docs/blob/f5e17ae1c680a475e980230d4d96a36db2c7afcd/pve-storage-pbs.adoc
Anyway, I added some additional changes since there were inconsistencies. Also for future reference, links don't work in code blocks (so the one for priority was invisible in the generated document).
I added CIFS support and the new feature from pbs for namespaces so that it is possible to mount pbs namespaces with pve_cluster_prio0 and pve_cluster_prio1 it is possible to define which link has the higher priority.