Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pvesh module_util to reflect upstream changes #38

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Update pvesh module_util to reflect upstream changes #38

merged 2 commits into from
Sep 18, 2018

Conversation

SniperCZE
Copy link
Contributor

There was a little change in output of pvesh in august (no 200 status line in result when OK + default json export changed to pretty tables) which needs to be reflected in pvesh ansible module.

Proxmox changed default output format from json to human-readable pretty tables.
@HenrikWMG
Copy link

Just wanna say, that i applied that Pull Request on my setup. it solved my Issues. Ty

@lae
Copy link
Owner

lae commented Sep 9, 2018

Some tests are failing for PVE 4.x it looks like, but I have #33 open with regards to that.

PVE 5.x tests still seem to be failing here however: https://travis-ci.org/lae/ansible-role-proxmox/jobs/424784386#L1594

If you can take a look at that and fix that, I'll merge this - otherwise it might still be a bit before I can take a closer look at what might be causing that failure.

@lae
Copy link
Owner

lae commented Sep 18, 2018

notes

root@proxmox-test:~# /usr/bin/pvesh get access/users/root@pam --output=json
Use of uninitialized value in string eq at /usr/share/perl5/PVE/CLIFormatter.pm line 390.
{"enable":1,"groups":[]}
root@proxmox-test:~# /usr/bin/pvesh get access/users/root@pam --output=json 2>/dev/null
{"enable":1,"groups":[]}

@lae
Copy link
Owner

lae commented Sep 18, 2018

someone filed a bug upstream that's most likely related (same error, same line) https://bugzilla.proxmox.com/show_bug.cgi?id=1914

return if $result_schema->{type} eq 'null'; from /usr/share/perl5/PVE/CLIFormatter.pm

@lae lae changed the title Reflection of changes in new version of pvesh Update pvesh module_util to reflect upstream changes Sep 18, 2018
lae added a commit that referenced this pull request Sep 18, 2018
Merge branch 'SniperCZE:develop' into develop
@lae
Copy link
Owner

lae commented Sep 18, 2018

Added comment to the bug and the small hotfix https://bugzilla.proxmox.com/show_bug.cgi?id=1914#c1

Patch seems to have worked, it looks like I needed to update the tests to get JSON output from pvesh as well so I'm waiting for that build to finish before merging.

@lae lae merged commit 3e92208 into lae:develop Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants