Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pvesh module_util to reflect upstream changes #38

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Update pvesh module_util to reflect upstream changes #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bca092
Force using JSON as output format of pvesh
SniperCZE Sep 5, 2018
3e92208
There is no status line when everything is OK
SniperCZE Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions module_utils/pvesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,16 @@ def run_command(handler, resource, **params):
command = [
"/usr/bin/pvesh",
handler,
resource]
resource,
"--output=json"]
for parameter, value in params.iteritems():
command += ["-{}".format(parameter), "{}".format(value)]

pipe = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
(result, stderr) = pipe.communicate()
stderr = stderr.splitlines()

if stderr[0] == "200 OK":
if len(stderr) == 0:
if not result:
return {u"status": 200}

Expand Down